w3c: fix HTML syntax errors #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes shaarli#64 All pages: - add `urlencode` when passing the version to a custom stylesheet; - set meaningful values of `alt` and `title` for QR-Code images. Install page: - the form's `action` attribute must be non-empty; - the `valign` attribute is deprecated. Signed-off-by: VirtualTam <virtualtam@flibidi.org>
|
Tested, got that sweet html5 compliance. Nothing special to report 🎉 OK to merge. |
|
Thanks @virtualtam |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the remaining W3C validation errors reported in #64
All pages:
urlencodewhen passing the version to a custom stylesheet;altandtitlefor QR-Code images.Install page:
actionattribute must be non-empty;valignattribute is deprecated.To validate the install page, you may need to comment the session check section at the beginning of the
install()method inindex.php(else, the session check will fail, and there'll be nothing to validate ;-) ).