Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS feed validation #914

Open
Lucas-C opened this issue Aug 4, 2017 · 2 comments
Open

RSS feed validation #914

Lucas-C opened this issue Aug 4, 2017 · 2 comments
Assignees
Labels
cleanup code cleanup and refactoring enhancement

Comments

@Lucas-C
Copy link

Lucas-C commented Aug 4, 2017

Hello.

I checked Shaarli RSS stream with the W3C validor out of curiosity, and I got 2 minor warnings:
https://validator.w3.org/feed/check.cgi?url=https%3A%2F%2Fchezsoi.org%2Fshaarli%2F%3Fdo%3Datom

  • self reference doesn't match document location: because of HTTP vs HTTPS
  • label should not contain HTML: because of the escaped &

I'm going to look at it

@Lucas-C
Copy link
Author

Lucas-C commented Aug 6, 2017

I fixed a few error & warnings, but some warnings remain that I don't see how to fix:

If do not use htmlspecialchars, the inserted strings can contain breaking characters (or an &amp; that is not allowed by the validator), and using <CDATA[[ is not supported by all the validators I tested.

IHMO it is OK that way

@Lucas-C
Copy link
Author

Lucas-C commented Aug 6, 2017

And for the "self reference doesn't match document location" warning, it was just a matter of using proxy_set_header X-Forwarded-Proto $scheme in my nginx configuration

@virtualtam virtualtam added this to the 0.9.1 milestone Aug 7, 2017
@virtualtam virtualtam added the cleanup code cleanup and refactoring label Aug 7, 2017
Lucas-C added a commit to Lucas-C/Shaarli that referenced this issue Aug 9, 2017
Lucas-C added a commit to Lucas-C/Shaarli that referenced this issue Aug 9, 2017
Lucas-C added a commit to Lucas-C/Shaarli that referenced this issue Aug 10, 2017
@virtualtam virtualtam modified the milestones: 0.9.1, 0.9.2 Aug 22, 2017
@ArthurHoaro ArthurHoaro modified the milestones: 0.9.2, 0.9.3 Oct 7, 2017
Lucas-C added a commit to Lucas-C/Shaarli that referenced this issue Oct 23, 2017
@ArthurHoaro ArthurHoaro modified the milestones: 0.9.3, 0.10.0 Nov 18, 2017
@virtualtam virtualtam modified the milestones: 0.10.0, 0.10.1 Jan 10, 2018
virtualtam pushed a commit to virtualtam/Shaarli that referenced this issue Feb 14, 2018
virtualtam pushed a commit to virtualtam/Shaarli that referenced this issue Mar 19, 2018
@ArthurHoaro ArthurHoaro modified the milestones: 0.10.1, 0.10.2 Jul 29, 2018
@ArthurHoaro ArthurHoaro modified the milestones: 0.10.2, 0.10.3 Aug 11, 2018
virtualtam pushed a commit to virtualtam/Shaarli that referenced this issue Oct 12, 2018
@virtualtam virtualtam modified the milestones: 0.10.3, 0.11.0 Feb 23, 2019
@ArthurHoaro ArthurHoaro modified the milestones: 0.11.0, 0.11.1 Jul 27, 2019
@ArthurHoaro ArthurHoaro modified the milestones: 0.11.1, 0.11.2 Aug 7, 2019
@ArthurHoaro ArthurHoaro modified the milestones: 0.12.0, 0.12.1 Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup code cleanup and refactoring enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants