Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make update check optional #34

Closed
nodiscc opened this issue Oct 22, 2014 · 4 comments
Closed

Make update check optional #34

nodiscc opened this issue Oct 22, 2014 · 4 comments
Milestone

Comments

@nodiscc
Copy link
Member

nodiscc commented Oct 22, 2014

#5 (comment):

About the update check, imho it should follow such guidelines:
The user is fully aware of it existence.
The user must enable it himself
The user must be aware of the privacy concern (privacy vs. function)

Totally agree. Maybe a checkbox at setup and in the configure dialog:
[ ] Automatically check for updates. This will periodically check the author's code repository for new versions. Your current version is $shaarli_version. You can also stay informed of latest updates by subscribing to the releases feed

We can already add a ENABLE_UPDATECHECK config option and checkUpdate() should only run if set to 1. What should be the default value?

Is this ok?

@e2jk
Copy link

e2jk commented Oct 22, 2014

Yes

@nodiscc nodiscc added this to the 0.9beta milestone Dec 2, 2014
@virtualtam
Copy link
Member

The default value may depend on how often new Shaarli revisions are released:

  • too frequent notifications may appear intrusive for the user;
  • no notifcation at all would prevent users from being aware of new features and bug fixes.

As Shaarli is very simple and stable (mine's been running for a couple years before I stumbled upon this fork), updates could be turned off by default, and, for users feeling adventurous, be available through a config option.

Maybe the way the user is notified of a new version could be improved: currently, the version number in the footer is blinking, which:

  • may not be the most noticeable place to display it, the Add link page would be more appropriate;
  • is visually a bit old school (last time I went to the Doctor's was because of Blinking Bad ^_^).

@nodiscc
Copy link
Member Author

nodiscc commented Dec 6, 2014

too frequent notifications may appear intrusive for the user

Yes, I'd prefer a slow release cycle (add improvements, fixes, test them, only release when there are enough significant changes). Users who want to test the latest version can always grab it from master.

users feeling adventurous

Releases should only be done when there is no risk for users.

updates could be turned off by default

Depends. If something bad happens (security issue, risk of data loss) it would be better to have it enabled by default. I think the user should be asked for this during the install process.

the way the user is notified of a new version could be improved.
the footer may not be the most noticeable place to display it

The page footer is already included in the "Edit link" dialog, which is called when you use the bookmarklet (certainly one of the most used features), and on the "Add link" page. So I think it's visible enough.

blinking

If you have something else to suggest, go ahead. Mind that it should not bee too intrusive, and should not depend on javascript.

ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Feb 20, 2015
  * Add a check box at installation (checked by default)
  * Add a check box in configuration page
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Feb 20, 2015
  * Add a check box at installation (checked by default)
  * Add a check box in configuration page
e2jk added a commit that referenced this issue Feb 21, 2015
@e2jk
Copy link

e2jk commented Feb 21, 2015

Fixed in #120.

@e2jk e2jk closed this as completed Feb 21, 2015
Knah-Tsaeb pushed a commit to Knah-Tsaeb/myShaarli that referenced this issue May 5, 2015
  * Add a check box at installation (checked by default)
  * Add a check box in configuration page
@virtualtam virtualtam modified the milestones: 0.9.0, 0.5.0 Jul 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants