-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make update check optional #34
Comments
Yes |
The default value may depend on how often new Shaarli revisions are released:
As Shaarli is very simple and stable (mine's been running for a couple years before I stumbled upon this fork), updates could be turned off by default, and, for users feeling adventurous, be available through a config option. Maybe the way the user is notified of a new version could be improved: currently, the version number in the footer is blinking, which:
|
Yes, I'd prefer a slow release cycle (add improvements, fixes, test them, only release when there are enough significant changes). Users who want to test the latest version can always grab it from
Releases should only be done when there is no risk for users.
Depends. If something bad happens (security issue, risk of data loss) it would be better to have it enabled by default. I think the user should be asked for this during the install process.
The page footer is already included in the "Edit link" dialog, which is called when you use the bookmarklet (certainly one of the most used features), and on the "Add link" page. So I think it's visible enough.
If you have something else to suggest, go ahead. Mind that it should not bee too intrusive, and should not depend on javascript. |
* Add a check box at installation (checked by default) * Add a check box in configuration page
* Add a check box at installation (checked by default) * Add a check box in configuration page
Fixed in #120. |
* Add a check box at installation (checked by default) * Add a check box in configuration page
#5 (comment):
We can already add a
ENABLE_UPDATECHECK
config option andcheckUpdate()
should only run if set to 1. What should be the default value?Is this ok?
The text was updated successfully, but these errors were encountered: