Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batch "add multiple links" feature #137

Closed
s1dh opened this issue Mar 4, 2015 · 7 comments · Fixed by #1587
Closed

batch "add multiple links" feature #137

s1dh opened this issue Mar 4, 2015 · 7 comments · Fixed by #1587
Labels
Milestone

Comments

@s1dh
Copy link

s1dh commented Mar 4, 2015

When we use one browser's window per topic search, it could be handy to save all the tabs in that window with the same tags in shaarli (like Command + Shift + D in Chrome osx version e.g.)

Of course , and as it hsas been said in others issues, copy/paste tags is possible for each tab we want to bookmark, but I found that way quite overkill.

@nodiscc
Copy link
Member

nodiscc commented Mar 4, 2015

The way I see it there's no way to add a browser-wide shortcut for this because it's outside Shaarli's scope (how could it know about your open tabs?).

It was proposed in #115 (comment) to make the Add link dialog URL input field multi-line (<textarea>), and add each line as a separate link. So the workflow would go like:

  • Open the Add link dialog (/?do=addlink)
  • Save all your tabs to a browser bookmarks folder and copy/paste the folder (screenshot) to the Add link field or copy URLs one-by-one to the Add link field
  • Click the Add link button.
  • You are sent to an Edit link dialog (?do=editlink) for the first URL you entered, where you are able to edit the title, description, private/public flag, tags...
  • Click Save to validate
  • You are sent to an Edit link dialog for the second URL which retains the tags you entered for the previous one.
  • Clicking Save sends you to the Edit link dialog for the next URL, and retains the tags you just entered, and so on...

Quick visual overview of the workflow:
2015-03-04-note-12-31

@s1dh
Copy link
Author

s1dh commented Mar 4, 2015

Sorry for being too much naive , while reading to this : https://stackoverflow.com/questions/11114395/get-urls-of-all-open-tabs-in-chrome-and-send-it-to-a-web-service

I thought it was possible to know the url of all open tabs in javascript (maybe it depends of the browser ).

Your workflow is a way "longer" that detecting all open tabs but it is quite better than the actual workflow (copy/paste) I have.

@nodiscc
Copy link
Member

nodiscc commented Mar 4, 2015

https://stackoverflow.com/questions/6553334/how-to-get-the-url-of-currently-opened-tabs-in-all-browsers-with-php-or-javascri

You can't, this information is just not available via any standard interface (except for a window you already have a reference to). You can see why. You wouldn't want the site owner for one of your tabs to be able to know what all your other tabs were showing, that would be a massive invasion of your privacy.

@nodiscc nodiscc modified the milestone: 1.1 Mar 13, 2015
@virtualtam virtualtam modified the milestones: 1.1, 0.7.0 Jul 30, 2015
@virtualtam virtualtam mentioned this issue Nov 3, 2015
5 tasks
@ArthurHoaro ArthurHoaro modified the milestones: 0.7.0, 0.7.1 May 14, 2016
@virtualtam virtualtam modified the milestones: 0.9.0, 0.8.0 Jul 23, 2016
@ArthurHoaro ArthurHoaro modified the milestones: 0.9.0, 0.9.1 Jan 25, 2017
@ArthurHoaro ArthurHoaro removed this from the 0.9.0 milestone Jan 25, 2017
@ArthurHoaro
Copy link
Member

Your workflow seems rather complicated to accomplish @nodiscc. What about a textarea with one URL per line, with default tags and private status for all of them ; then users can eventually edit the description if they want to?

@nicolasdanelon
Copy link

@nodiscc if you click the cancel button you are canceling that link. You should add a new button for cancel all. what do you think about that?
@ArthurHoaro what about a new accordion view? like this one of course we can do it with out jquery
every "section" in the example will be a "add link" form. in php we'll have a foreach and then ready. we can add all the links. theoretically.

@nodiscc
Copy link
Member

nodiscc commented May 10, 2017

@ArthurHoaro You are both right, @nicolasdanelon's solution looks better:

  • Single textearea supporting one URL per line + a global tags and private setting
  • Click OK -> Show a single page presenting several Edit link dialogs/divs, one for each submitted URL; for each one the Title field is prefilled as per the page title, and tags and Private status are prefilled as per the global setting chosen before.
  • Edit individual links (or not), click Save all
  • An accordion/collapsing view would be a nice extra
  • Page title requests could benefit from being done in parallel (else the operation might take a long time when adding many links)

@ArthurHoaro
Copy link
Member

I agree, this would be a nice feature. However, I'm pushing the milestone since this would be easier to take down with the bunch of refactoring/improvements planed for the next versions.

@ArthurHoaro ArthurHoaro modified the milestones: 0.11.0, 0.9.1 May 25, 2017
@ArthurHoaro ArthurHoaro modified the milestones: 0.11.0, 0.11.1 Jul 27, 2019
@ArthurHoaro ArthurHoaro modified the milestones: 0.11.1, 0.11.2 Aug 7, 2019
@ArthurHoaro ArthurHoaro modified the milestones: 0.12.0, 0.12.1 Sep 3, 2020
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Oct 10, 2020
This changes creates a new form in addlink page allowing to create
multiple bookmarks at once more easily. It focuses on re-using as much
existing code and template component as  possible.

These changes includes:
  - a new form in addlink (hidden behind a button by default),
containing a text area for URL, and tags/private status to apply to
created links
  - this form displays a new template called editlink.batch, itself
including editlink template multiple times
  - User interation in this new templates are handle by a new JS script
(shaare-batch.js) making AJAX requests, and therefore does not need page
reloading
  - ManageShaareController has been split into 3 distinct controllers:
    + ShaareAdd: displays addlink template
    + ShaareManage: various operation applied on existing shaares
(change visibility, pin, deletion, etc.)
    + ShaarePublish: handles creation/edit forms and saving Shaare's
form
  - Updated translations

Fixes shaarli#137
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Oct 10, 2020
This changes creates a new form in addlink page allowing to create
multiple bookmarks at once more easily. It focuses on re-using as much
existing code and template component as  possible.

These changes includes:
  - a new form in addlink (hidden behind a button by default),
containing a text area for URL, and tags/private status to apply to
created links
  - this form displays a new template called editlink.batch, itself
including editlink template multiple times
  - User interation in this new templates are handle by a new JS script
(shaare-batch.js) making AJAX requests, and therefore does not need page
reloading
  - ManageShaareController has been split into 3 distinct controllers:
    + ShaareAdd: displays addlink template
    + ShaareManage: various operation applied on existing shaares
(change visibility, pin, deletion, etc.)
    + ShaarePublish: handles creation/edit forms and saving Shaare's
form
  - Updated translations

Fixes shaarli#137
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Oct 15, 2020
This changes creates a new form in addlink page allowing to create
multiple bookmarks at once more easily. It focuses on re-using as much
existing code and template component as  possible.

These changes includes:
  - a new form in addlink (hidden behind a button by default),
containing a text area for URL, and tags/private status to apply to
created links
  - this form displays a new template called editlink.batch, itself
including editlink template multiple times
  - User interation in this new templates are handle by a new JS script
(shaare-batch.js) making AJAX requests, and therefore does not need page
reloading
  - ManageShaareController has been split into 3 distinct controllers:
    + ShaareAdd: displays addlink template
    + ShaareManage: various operation applied on existing shaares
(change visibility, pin, deletion, etc.)
    + ShaarePublish: handles creation/edit forms and saving Shaare's
form
  - Updated translations

Fixes shaarli#137
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Oct 20, 2020
This changes creates a new form in addlink page allowing to create
multiple bookmarks at once more easily. It focuses on re-using as much
existing code and template component as  possible.

These changes includes:
  - a new form in addlink (hidden behind a button by default),
containing a text area for URL, and tags/private status to apply to
created links
  - this form displays a new template called editlink.batch, itself
including editlink template multiple times
  - User interation in this new templates are handle by a new JS script
(shaare-batch.js) making AJAX requests, and therefore does not need page
reloading
  - ManageShaareController has been split into 3 distinct controllers:
    + ShaareAdd: displays addlink template
    + ShaareManage: various operation applied on existing shaares
(change visibility, pin, deletion, etc.)
    + ShaarePublish: handles creation/edit forms and saving Shaare's
form
  - Updated translations

Fixes shaarli#137
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Oct 27, 2020
This changes creates a new form in addlink page allowing to create
multiple bookmarks at once more easily. It focuses on re-using as much
existing code and template component as  possible.

These changes includes:
  - a new form in addlink (hidden behind a button by default),
containing a text area for URL, and tags/private status to apply to
created links
  - this form displays a new template called editlink.batch, itself
including editlink template multiple times
  - User interation in this new templates are handle by a new JS script
(shaare-batch.js) making AJAX requests, and therefore does not need page
reloading
  - ManageShaareController has been split into 3 distinct controllers:
    + ShaareAdd: displays addlink template
    + ShaareManage: various operation applied on existing shaares
(change visibility, pin, deletion, etc.)
    + ShaarePublish: handles creation/edit forms and saving Shaare's
form
  - Updated translations

Fixes shaarli#137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants