Skip to content

Conversation

@dpnova
Copy link
Contributor

@dpnova dpnova commented Jan 29, 2026

No description provided.

@dpnova dpnova marked this pull request as ready for review January 29, 2026 02:25
Copilot AI review requested due to automatic review settings January 29, 2026 02:25
@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.93%. Comparing base (fec0bf1) to head (867677f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   96.90%   96.93%   +0.03%     
==========================================
  Files           1        1              
  Lines          97       98       +1     
  Branches       12       12              
==========================================
+ Hits           94       95       +1     
  Misses          3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds visitor utility functions for printing DAG structures in different formats.

Changes:

  • Adds createPrintVisitor function for simple indentation-based graph visualization
  • Adds createTreeVisitor function for tree-like visualization with box-drawing characters
  • Exports the new visitor functions from the main index module
  • Includes comprehensive test coverage for both visitor types

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
lib/visitors.ts Implements two visitor factory functions for printing graph structures with different formatting styles
test/visitors.spec.ts Comprehensive test suite covering default behavior, custom configurations, and various graph structures
index.ts Exports the new visitor utilities from the main module

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Owner

@sha1n sha1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I only want a few name changes - see comments.

Copilot AI review requested due to automatic review settings January 30, 2026 02:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dpnova dpnova requested a review from sha1n January 30, 2026 02:07
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Owner

@sha1n sha1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sha1n
Copy link
Owner

sha1n commented Jan 30, 2026

@dpnova Just resolve the conflicts (sorry about that) and push and I'll rebase.

🙏

@sha1n sha1n changed the title Print visitor feat: Add DAG format visitors implementations Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants