-
Notifications
You must be signed in to change notification settings - Fork 1
feat: Add DAG format visitors implementations #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #66 +/- ##
==========================================
+ Coverage 96.90% 96.93% +0.03%
==========================================
Files 1 1
Lines 97 98 +1
Branches 12 12
==========================================
+ Hits 94 95 +1
Misses 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds visitor utility functions for printing DAG structures in different formats.
Changes:
- Adds
createPrintVisitorfunction for simple indentation-based graph visualization - Adds
createTreeVisitorfunction for tree-like visualization with box-drawing characters - Exports the new visitor functions from the main index module
- Includes comprehensive test coverage for both visitor types
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/visitors.ts | Implements two visitor factory functions for printing graph structures with different formatting styles |
| test/visitors.spec.ts | Comprehensive test suite covering default behavior, custom configurations, and various graph structures |
| index.ts | Exports the new visitor utilities from the main module |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sha1n
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I only want a few name changes - see comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
sha1n
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
|
@dpnova Just resolve the conflicts (sorry about that) and push and I'll rebase. 🙏 |
No description provided.