disable-lint-thimble #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgupta7857
force-pushed
the
disable-lint
branch
2 times, most recently
from
5eb1061 to
6776486
Compare
humphd
reviewed
Apr 23, 2017
| exports.TOGGLE_ACTIVE_LINE = "view.toggleActiveLine"; // EditorOptionHandlers.js _getToggler() | ||
| exports.TOGGLE_WORD_WRAP = "view.toggleWordWrap"; // EditorOptionHandlers.js _getToggler() | ||
| exports.TOGGLE_ALLOW_JAVASCRIPT = "cmd.toggleAllowJavaScript"; // EditorOptionsHandlers.js _getToggler() | ||
| exports.TOGGLE_ALLOW_LINT = "cmd.toggleAllowLint"; // EditorOptionsHandlers.js _getToggler() |
humphd
reviewed
Apr 23, 2017
| WORD_WRAP = "wordWrap", | ||
| INDENT_LINE_COMMENT = "indentLineComment", | ||
| ALLOW_JAVASCRIPT = "allowJavaScript", | ||
| ALLOW_LINT = "interactive-linter", |
There was a problem hiding this comment.
Don't need any of the changes to this file, you can revert all this.
humphd
reviewed
Apr 23, 2017
| // Constants for the preferences referred to in this file | ||
| var SHOW_LINE_NUMBERS = "showLineNumbers", | ||
| STYLE_ACTIVE_LINE = "styleActiveLine", | ||
| WORD_WRAP = "wordWrap", |
humphd
reviewed
Apr 23, 2017
| PostMessageTransport.reload(); | ||
| break; | ||
| case "BRAMBLE_ENABLE_LINT": | ||
| PreferencesManager.set("allowLint", true); |
There was a problem hiding this comment.
You have to set this for the proper pref in your extension:
PreferencesManager.getExtensionPrefs("interactive-linter").set("enabled" true);I think. Test that.
humphd
reviewed
Apr 23, 2017
| PostMessageTransport.reload(); | ||
| break; | ||
| case "BRAMBLE_DISABLE_LINT": | ||
| PreferencesManager.set("allowLint", false); |
humphd
suggested changes
Apr 23, 2017
| }); | ||
| }); | ||
| // Listen for changes to allow javascript | ||
| var Lint = PreferencesManager.getExtensionPrefs("interactive-linter"); |
| }); | ||
| // Listen for changes to allow javascript | ||
| var Lint = PreferencesManager.getExtensionPrefs("interactive-linter"); | ||
| Lint.on("change", "allowLint", function () { |
There was a problem hiding this comment.
This is wrong. Check out https://github.com/mozilla/brackets/pull/702/files which is pretty similar to what you're doing.
Owner
Author
|
@humphd I made the changes you suggested on the brackets side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@humphd so for release 0.4 my task is to add a toggle button for linting [enable-disable]
please reivew, my code on the brackets side. for some reason thimble isn't loading anymore and I can't figure out why
I know i need to fix my indentation for release 0.3. will do after work tonight
i will also be posting thimble code change for this task and link it here
mozilla/thimble.mozilla.org#2024