Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ RUN python3 -m pip install --no-cache-dir --upgrade pip setuptools wheel html5li
&& python3 -m pip install --no-cache-dir -e "python[${BUILD_TYPE}]" --extra-index-url https://download.pytorch.org/whl/cu${CUINDEX} \
&& if [ "$CUDA_VERSION" = "12.8.1" ]; then \
python3 -m pip install --no-cache-dir nvidia-nccl-cu12==2.27.5 --force-reinstall --no-deps ; \
python3 -m pip install --no-cache-dir https://github.com/sgl-project/whl/releases/download/v0.2.5/sgl_kernel-0.2.5+cu128-cp39-abi3-manylinux2014_x86_64.whl --force-reinstall --no-deps ; \
python3 -m pip install --no-cache-dir https://github.com/sgl-project/whl/releases/download/v0.2.6/sgl_kernel-0.2.6+cu128-cp39-abi3-manylinux2014_x86_64.whl --force-reinstall --no-deps ; \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability, avoid hardcoding the version number. Extract the version from sgl-kernel/python/sgl_kernel/version.py to ensure the Docker build uses the correct version.

      SGL_KERNEL_VERSION=$(awk -F '"' '/__version__/ {print $2}' sgl-kernel/python/sgl_kernel/version.py) && python3 -m pip install --no-cache-dir "https://github.com/sgl-project/whl/releases/download/v${SGL_KERNEL_VERSION}/sgl_kernel-${SGL_KERNEL_VERSION}+cu128-cp39-abi3-manylinux2014_x86_64.whl" --force-reinstall --no-deps ; \

fi

# Build and install NVSHMEM + DeepEP
Expand Down
2 changes: 1 addition & 1 deletion sgl-kernel/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ build-backend = "scikit_build_core.build"

[project]
name = "sgl-kernel"
version = "0.2.5"
version = "0.2.6"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability, avoid hardcoding the version. Use a dynamic version by reading it from python/sgl_kernel/version.py. scikit-build-core supports this via dynamic = ["version"] in the [project] table and configuring a version provider in [tool.scikit-build.metadata].

description = "Kernel Library for SGLang"
readme = "README.md"
requires-python = ">=3.9"
Expand Down
2 changes: 1 addition & 1 deletion sgl-kernel/pyproject_cpu.toml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ build-backend = "scikit_build_core.build"

[project]
name = "sgl-kernel"
version = "0.2.5"
version = "0.2.6"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability, avoid hardcoding the version. Use a dynamic version by reading it from python/sgl_kernel/version.py. scikit-build-core supports this via dynamic = ["version"] in the [project] table and configuring a version provider in [tool.scikit-build.metadata].

description = "Kernel Library for SGLang"
readme = "README.md"
requires-python = ">=3.9"
Expand Down
2 changes: 1 addition & 1 deletion sgl-kernel/pyproject_rocm.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ build-backend = "setuptools.build_meta"

[project]
name = "sgl-kernel"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability, avoid hardcoding the version. Use a dynamic version by reading it from python/sgl_kernel/version.py. For setuptools, add dynamic = ["version"] to the [project] table and configure [tool.setuptools.dynamic] to read the version from the file (e.g., using attr: sgl_kernel.version.__version__).

version = "0.2.5"
version = "0.2.6"
description = "Kernel Library for SGLang"
readme = "README.md"
requires-python = ">=3.9"
Expand Down
2 changes: 1 addition & 1 deletion sgl-kernel/python/sgl_kernel/version.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "0.2.5"
__version__ = "0.2.6"
Loading