Skip to content

[fix]: PyO3 macOS linking and consolidate on tracing for logging #5856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

slin1237
Copy link
Collaborator

@slin1237 slin1237 commented Apr 28, 2025

Motivation

  1. When building the project on macOS, we encountered linking errors with PyO3 - the linker couldn't find Python symbols like _PyBaseObject_Type and others
  2. We had redundant logging dependencies (log and tracing)

Modifications

  1. Added .cargo/config.toml with platform-specific configurations (default to Linux support, added Mac Arm and X86 chip, no windows support)
  2. Removed unnecessary dependencies in Cargo.toml, including env_logger, log, and chrono
  3. Migrated from log to tracing in router.rs

Checklist

@slin1237 slin1237 force-pushed the slin/logging-update branch from acd178d to 82e146f Compare April 28, 2025 19:16
@slin1237
Copy link
Collaborator Author

compiled in both linux and mac
Linux:
Screenshot 2025-04-28 at 12 05 12 PM
Mac
Screenshot 2025-04-28 at 12 04 45 PM

@slin1237 slin1237 requested review from merrymercy and zhyncs April 28, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant