-
Notifications
You must be signed in to change notification settings - Fork 3k
Hierarchical Caching Refactoring and Fixing TP issue #4082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
merrymercy
reviewed
Mar 6, 2025
Edenzzzz
reviewed
Mar 6, 2025
6 tasks
Edenzzzz
reviewed
Mar 7, 2025
Do we have unit test for this? |
I will add a set of unit tests for hierarchical caching and incorporate them into CI in a separate PR. This PR is a fix for a rather emergent issue of this feature. |
6 tasks
hebiao064
pushed a commit
to hebiao064/sglang
that referenced
this pull request
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a follow-up PR to #2693, primarily focus on two things:
tp_size > 1
, which was discussed by [Bug] HiCacheController gets stuck when testing with multiple long text documents #3998 and Hierarchical Caching supports MLA #4009Modifications
Checklist