Skip to content

Conversation

xiezhq-hermann
Copy link
Collaborator

Motivation

This is a follow-up PR to #2693, primarily focus on two things:

  1. Fixing concurrency issue in the case of tp_size > 1, which was discussed by [Bug] HiCacheController gets stuck when testing with multiple long text documents #3998 and Hierarchical Caching supports MLA #4009
  2. Introducing layer-wise KV cache loading and synchronization

Modifications

  1. A new completion checking of hierarchical cache activities with order enforcement across TP workers
  2. New event and counters to enable layer-wise KV cache loading, more policies to be added
  3. Some style changes

Checklist

@zhyncs
Copy link
Member

zhyncs commented Mar 12, 2025

Do we have unit test for this?

@xiezhq-hermann
Copy link
Collaborator Author

Do we have unit test for this?

I will add a set of unit tests for hierarchical caching and incorporate them into CI in a separate PR. This PR is a fix for a rather emergent issue of this feature.

@zhyncs zhyncs merged commit 10b544a into main Mar 12, 2025
2 of 20 checks passed
@zhyncs zhyncs deleted the xiezhq-hicache branch March 12, 2025 18:22
hebiao064 pushed a commit to hebiao064/sglang that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants