[router] Add gRPC E2E test suite #11790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgl-router/py_test/e2e_grpc/features/test_openai_server_ebnf.py
Outdated
Show resolved
Hide resolved
sgl-router/py_test/e2e_grpc/features/test_openai_server_hidden_states.py
Outdated
Show resolved
Hide resolved
sgl-router/py_test/e2e_grpc/validation/test_large_max_new_tokens.py
Outdated
Show resolved
Hide resolved
key4ng
requested review from
ByronHsu,
merrymercy,
slin1237 and
zhyncs
as code owners
| assert len(response.choices[0].message.content) > 0 | ||
|
|
||
|
|
||
| class TestReasoningContentWithoutParser(CustomTestCase): |
There was a problem hiding this comment.
can we remove this test or rename it?
Because it is basically duplicated to test_nonstreaming_separate_reasoning_false above.
| import requests | ||
|
|
||
| _TEST_DIR = Path(__file__).parent | ||
| sys.path.insert(0, str(_TEST_DIR.parent)) |
There was a problem hiding this comment.
why do we need this for all uts?
There was a problem hiding this comment.
This adds the e2e_grpc directory to Python's module search path, allowing from util import ... to work
slin1237
reviewed
Oct 21, 2025
| python3 -m pip --no-cache-dir install --upgrade --break-system-packages genai-bench==0.0.2 | ||
| pytest -m e2e -s -vv -o log_cli=true --log-cli-level=INFO | ||
| - name: Run Python E2E gRPC tests |
There was a problem hiding this comment.
shall we use another workflow?
to speed things up
There was a problem hiding this comment.
yeah good point. we can do that later once the openai router ci is also added
xjpang
pushed a commit
to xjpang/sglang
that referenced
this pull request
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The SGLang router supports gRPC connections but lacks end-to-end tests to validate this functionality. This PR adds comprehensive test coverage for gRPC endpoints to ensure reliability and catch regressions.
Modifications
Accuracy Tests
https://github.com/sgl-project/sglang/actions/runs/18694641875/job/53308814787?pr=11790
Benchmarking and Profiling
Checklist