[DataFlow runtime] E0 — layout consolidation: runtime/ is substrate-only (move-only)#638
Open
maocheng23 wants to merge 2 commits into
Open
[DataFlow runtime] E0 — layout consolidation: runtime/ is substrate-only (move-only)#638maocheng23 wants to merge 2 commits into
maocheng23 wants to merge 2 commits into
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
This was referenced Jul 1, 2026
maocheng23
force-pushed
the
dataflow-up-29-training-managers
branch
from
3ef9f34 to
f512828
Compare
maocheng23
force-pushed
the
dataflow-up-30-e0-layout
branch
from
80b906b to
1e3e516
Compare
…nly (move-only)
Move the domain planes out of specforge/runtime/ into their S-homes:
- specforge/runtime/training/* -> specforge/training/{controller,backend,strategies/{base,registry}}.py
- specforge/runtime/inference/* -> specforge/inference/{rollout_worker,capture,adapters/{eagle3,dflash}}.py
- specforge/modeling/target/** -> specforge/inference/target_engine/** (incl. sglang_backend/)
- specforge/runtime/launch.py -> specforge/launch.py
Every old path keeps a thin import shim re-exporting from the new home;
tests/scripts/examples switch to the new import paths. No behavior change.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
maocheng23
force-pushed
the
dataflow-up-30-e0-layout
branch
from
1e3e516 to
3ae106c
Compare
…cut to the new homes
specforge/runtime/{training,inference,launch} and the relocated
modeling/target modules are deleted instead of shimmed; the only in-repo
old-path importers (test_strategy_registry, modeling/target/__init__)
now import the new homes directly.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
maocheng23
force-pushed
the
dataflow-up-30-e0-layout
branch
from
7413592 to
5df35cd
Compare
maocheng23
requested review from
FlamingoPg,
FrankLeeeee,
shuaills and
sleepcoo
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E0 — Layout consolidation:
runtime/is substrate-only (move-only)Implements E0 of the reconciled plan (#630,
docs/roadmap/domain-refactor.md§E0): collapse the scattered execution code into one home per concern with zero functional change, so Phase E's composition work lands in the final "S" layout. Stacked on #637.The moves (plan §2.3 target tree)
runtime/training/{trainer,backend,strategy,registry}→training/{controller,backend,strategies/{base,registry}}runtime/inference/{rollout_worker,capture}→inference/;{sglang,dflash}_adapter→inference/adapters/{eagle3,dflash}modeling/target/{base,factory,eagle3,dflash}_target_model+sglang_backend/→inference/target_engine/runtime/launch.py→specforge/launch.pymodeling/target/keeps model definitions only (target_head,custom_backend);runtime/keeps onlycontracts.py+control_plane/+data_plane/The old module paths are removed outright (no re-export shims):
specforge/runtime/{training,inference,launch}and the relocatedmodeling/targetmodules are deleted, and every in-repo importer targets the new homes directly. The C/D review-fix commits (#636/#637) are merged in, with the fixes ported verbatim onto the moved homes (verified byte-identical to the up-29 sources modulo the import-path rewrites — an adversarial audit pass confirmed both the move-only property and the port).Gates
tests/test_runtimeon 8×H200: 240 OK (2 skip, 1 xfail) — the same count and results as the up-29 base, i.e. the suite passes unchanged.test_phase_b_gate.py(byte-identical capture/loss) passes within that run — a move-only change altered no tensor.🤖 Generated with Claude Code