[DataFlow runtime] Phase B4 — adopt the de-EAGLE3 surface (cutover + docs + gate)#635
Merged
jiapingW merged 1 commit intoJul 3, 2026
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
4e3c214 to
1d9060e
Compare
…docs + gate) Makes the Phase B abstractions load-bearing instead of forward-only scaffolding. 1. adapter cutover: SGLangAdapter / DFlashAdapter now call the engine's generic `capture(...)` instead of `generate_eagle3_data` / `generate_dflash_data` (which stay as byte-identical back-compat aliases). This is the dataflow runtime's real capture path, so `TargetEngine.capture()` is now exercised. 2. factory cutover: the dataflow test fixtures + online launch tests build targets via `get_target_engine(strategy=, backend=)`; the old `get_eagle3_target_model` / `get_dflash_target_model` stay as shims (legacy scripts untouched). 3. docs: runtime/inference/DESIGN.md, runtime/ARCHITECTURE.md, and the adapter docstrings now describe the boundary as `TargetEngine.capture` (sglang glue in SGLangCaptureBackend) instead of `Eagle3TargetModel.generate_eagle3_data`. 4. explicit B gate: tests/test_runtime/test_phase_b_gate.py — `capture() ≡ legacy generate_*_data()` **bytewise** (eagle3 + dflash), a stable captured-feature digest, and per-step-loss reproducibility through the full online capture→train path (which now routes through `capture()`), instead of relying only on the full-suite's indirect coverage. No behavior change: `capture()` dispatches to the legacy method, so byte-identical. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
7c6457c to
e6aaead
Compare
Base automatically changed from
dataflow-up-26-domain-trainer
to
dataflow-up-16-zerocopy
July 3, 2026 02:17
jiapingW
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase B — 4/4 (clean-up). Stacked on #633 (B3). Makes the Phase B abstractions load-bearing instead of forward-only scaffolding: after B1–B3 the new generic surface (
get_target_engine,TargetEngine.capture) existed but no production caller used it yet — callers still hitgenerate_eagle3_data/get_eagle3_target_model. This adopts it.SGLangAdapter/DFlashAdapternow call the engine's genericcapture(...)instead ofgenerate_eagle3_data/generate_dflash_data(kept as byte-identical back-compat aliases). This is the dataflow runtime's real capture path, soTargetEngine.capture()is now exercised end-to-end.get_target_engine(strategy=, backend=);get_eagle3_target_model/get_dflash_target_modelstay as shims (legacy scripts untouched).runtime/inference/DESIGN.md,runtime/ARCHITECTURE.md, and the adapter docstrings now describe the boundary asTargetEngine.capture(sglang glue behindSGLangCaptureBackend) instead ofEagle3TargetModel.generate_eagle3_data.tests/test_runtime/test_phase_b_gate.py:capture() ≡ legacy generate_*_data()bytewise (eagle3 + dflash), a stable captured-feature digest, and per-step-loss reproducibility through the full online capture→train path — instead of relying only on the full-suite's indirect coverage.No behavior change:
capture()dispatches to the legacy method.Validation (8×H200)
Full
tests/test_runtime218 OK (2 skip, 1 xfail) = the prior 214 + the 4 new gate tests. The new gate confirmscapture()is byte-identical to the legacy extraction for both eagle3 and dflash.With this, Phase B is complete. (Deferred to Phase E by decision: collapsing the per-
(algorithm × backend)engine classes into per-backend generic engines + aCaptureSpec, alongside themodels/targets/move — see plan.md §2.3.)🤖 Generated with Claude Code