[DataFlow runtime 1/7] Make SGLang target imports optional#594
Merged
Conversation
maocheng23
requested review from
FlamingoPg,
FrankLeeeee,
shuaills and
sleepcoo
as code owners
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
maocheng23
force-pushed
the
dataflow-up-1-sglang-guard
branch
from
fc4ee35 to
625971c
Compare
jiapingW
approved these changes
Jun 25, 2026
This was referenced Jun 26, 2026
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataFlow runtime — part 1/7 (base of the stack).
Wraps the
sglang.srt.*imports inspecforge/modeling/target/eagle3_target_model.pyintry/exceptsoimport specforge(and the HF / offline / draft paths) works even when the installed sglang version does not expose the exact symbols this file pins. The sglang target backend still requires a matching sglang and now surfaces a clear error at construction (SGLangEagle3TargetModel.from_pretrained) instead of crashing at import.Why: a sglang version skew currently breaks
import specforgeentirely, blocking users who do not use the sglang target backend at all. Risk: behavior-identical when sglang is present (imports run as before); only the no-sglang path changes. This is the single existing file the whole series modifies.Part of a 7-PR series adding the DataFlow runtime (
specforge/runtime/, milestones M1–M4). Verified on current upstreammain: all subpackages import and 65 component tests pass. The integration launcher (launch.py+train_eagle3_dataflow.py) and the end-to-end equivalence gates are a deliberate follow-up, not in this series.