rename Qwen3.5-4B Domino NPU launcher to include online mode#591
Merged
Conversation
curnane-lab
requested review from
FlamingoPg,
shuaills and
sleepcoo
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the examples/run_qwen3.5_4b_domino_online_npu.sh script to rename the variable NUM_GPUS to NUM_DEVICES to accurately reflect the use of NPU devices instead of GPUs. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
curnane-lab
changed the title
curnane-lab
changed the title
Contributor
Author
jiapingW
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The Domino training script for Qwen3.5-4B on NPU currently omits the
_onlinesuffix, while other online training launchers inexamples/consistently include it (e.g.,run_qwen3.5_4b_dflash_online_npu.sh,run_qwen3_8b_domino_online.sh). Sincescripts/train_domino.pyusesOnlineDominoModeland generates target outputs on-the-fly viatarget_model.generate_dflash_data(...), the mode is online. This rename makes the naming convention consistent.Modifications
examples/run_qwen3.5_4b_domino_npu.shtoexamples/run_qwen3.5_4b_domino_online_npu.sh.Checklist