-
Notifications
You must be signed in to change notification settings - Fork 37
Switch to pyproject.toml #1300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to pyproject.toml #1300
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR has conflicts, @ianhi please rebase and push updated version 🙏 |
This looks great - thanks for the contribution @ianhi! The build was failing due to changes not related to this PR, which I have now fixed in #1297. Can you rebase this PR and change the pins to the following in pyproject.toml:
Also, it looks like Black is complaining (perhaps the settings have changed slightly?), see https://github.com/sgkit-dev/sgkit/actions/runs/14207381471/job/39820084873?pr=1300, so can you run Thanks! |
Previously pip was generating a warning when trying to do an editable install
Somewhat relatedly do you know the person who maintains the cbgen package? I had to install that from source when trying to follow the sgkit tutorial because it doesn't have any builds for macos 15: limix/cbgen#18 |
Yes, it's @horta. |
When I tried to install in editable mode (force of habit) I ran into this deprecation warning:
I used ini2toml to do the initial conversion from
setup.cfg
topyproject.toml
then manually configured flake8 in.flake8
as flake8 does not support pyproject toml. Finally I added a line to the contributing docs about editable installs.changelog.rst
api.rst