forked from pixie-io/pixie
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: Originally I made cron scripts support only a cron expression to designate how frequently as script should be run. However, cron expressions look like they dont support second granularity. Instead, we can have cronscripts support two modes: cron expression (probably unsupported for now, as this is more difficult), and hardcoded seconds. Test Plan: This diff just adds some fields, but doesn't use them yet. Reviewers: vihang, nserrino Reviewed By: vihang Signed-off-by: Michelle Nguyen <michellenguyen@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11030 GitOrigin-RevId: 1580e3a
- Loading branch information
1 parent
b96594e
commit fc863b6
Showing
7 changed files
with
454 additions
and
207 deletions.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
src/cloud/cron_script/schema/000002_add_frequency_cron_scripts_table.down.sql
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
ALTER TABLE cron_scripts | ||
DROP COLUMN frequency_s; |
2 changes: 2 additions & 0 deletions
2
src/cloud/cron_script/schema/000002_add_frequency_cron_scripts_table.up.sql
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
ALTER TABLE cron_scripts | ||
ADD COLUMN frequency_s integer; |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.