Remove dnsmgr from cloud

Summary:
Now that certmgr is gone, and direct mode is deprecated, we don't need
to assign DNS names or SSL certs to clusters. Remove dnsmgr.
Note: skaffold won't remove the dnsmgr deployment, that will need to be cleaned
manually on release.

Test Plan: skaffold a dev cloud, deploy a vizier to it

Reviewers: michelle, philkuz

Reviewed By: michelle

JIRA Issues: PP-3335

Signed-off-by: Vihang Mehta <vihang@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D11226

.fossa.yml

@@ -260,38 +260,6 @@ analyze:
     type: go
     target: px.dev/pixie/src/cloud/config_manager/controller
     path: src/cloud/config_manager/controller
-  - name: px.dev/pixie/src/cloud/dnsmgr
-    type: go
-    target: px.dev/pixie/src/cloud/dnsmgr
-    path: src/cloud/dnsmgr
-  - name: px.dev/pixie/src/cloud/dnsmgr/controller
-    type: go
-    target: px.dev/pixie/src/cloud/dnsmgr/controller
-    path: src/cloud/dnsmgr/controller
-  - name: px.dev/pixie/src/cloud/dnsmgr/controllers/mock
-    type: go
-    target: px.dev/pixie/src/cloud/dnsmgr/controllers/mock
-    path: src/cloud/dnsmgr/controllers/mock
-  - name: px.dev/pixie/src/cloud/dnsmgr/dnsmgrenv
-    type: go
-    target: px.dev/pixie/src/cloud/dnsmgr/dnsmgrenv
-    path: src/cloud/dnsmgr/dnsmgrenv
-  - name: px.dev/pixie/src/cloud/dnsmgr/dnsmgrpb
-    type: go
-    target: px.dev/pixie/src/cloud/dnsmgr/dnsmgrpb
-    path: src/cloud/dnsmgr/dnsmgrpb
-  - name: px.dev/pixie/src/cloud/dnsmgr/dnsmgrpb/mock
-    type: go
-    target: px.dev/pixie/src/cloud/dnsmgr/dnsmgrpb/mock
-    path: src/cloud/dnsmgr/dnsmgrpb/mock
-  - name: px.dev/pixie/src/cloud/dnsmgr/load_certs
-    type: go
-    target: px.dev/pixie/src/cloud/dnsmgr/load_certs
-    path: src/cloud/dnsmgr/load_certs
-  - name: px.dev/pixie/src/cloud/dnsmgr/schema
-    type: go
-    target: px.dev/pixie/src/cloud/dnsmgr/schema
-    path: src/cloud/dnsmgr/schema
   - name: px.dev/pixie/src/cloud/indexer
     type: go
     target: px.dev/pixie/src/cloud/indexer

BUILD.bazel

@@ -63,7 +63,6 @@ gazelle(
 # gazelle:resolve go px.dev/pixie/src/cloud/auth/authpb //src/cloud/auth/authpb:auth_pl_go_proto
 # gazelle:resolve go px.dev/pixie/src/cloud/config_manager/configmanagerpb //src/cloud/config_manager/configmanagerpb:service_pl_go_proto
 # gazelle:resolve go px.dev/pixie/src/cloud/cron_script/cronscriptpb //src/cloud/cron_script/cronscriptpb:service_pl_go_proto
-# gazelle:resolve go px.dev/pixie/src/cloud/dnsmgr/dnsmgrpb //src/cloud/dnsmgr/dnsmgrpb:service_pl_go_proto
 # gazelle:resolve go px.dev/pixie/src/cloud/plugin/pluginpb //src/cloud/plugin/pluginpb:service_pl_go_proto
 # gazelle:resolve go px.dev/pixie/src/cloud/profile/profilepb //src/cloud/profile/profilepb:service_pl_go_proto
 # gazelle:resolve go px.dev/pixie/src/cloud/project_manager/projectmanagerpb //src/cloud/project_manager/projectmanagerpb:service_pl_go_proto

k8s/cloud/BUILD.bazel

@@ -26,7 +26,6 @@ CLOUD_IMAGE_MAP = {
     "gcr.io/pixie-oss/pixie-dev/cloud/auth_server_image": "//src/cloud/auth:auth_server_image",
     "gcr.io/pixie-oss/pixie-dev/cloud/config_manager_server_image": "//src/cloud/config_manager:config_manager_server_image",
     "gcr.io/pixie-oss/pixie-dev/cloud/cron_script_server_image": "//src/cloud/cron_script:cron_script_server_image",
-    "gcr.io/pixie-oss/pixie-dev/cloud/dnsmgr_server_image": "//src/cloud/dnsmgr:dnsmgr_server_image",
     "gcr.io/pixie-oss/pixie-dev/cloud/indexer_server_image": "//src/cloud/indexer:indexer_server_image",
     "gcr.io/pixie-oss/pixie-dev/cloud/job/create_admin_job_image": "//src/cloud/jobs/create_admin_user:create_admin_job_image",
     "gcr.io/pixie-oss/pixie-dev/cloud/metrics_server_image": "//src/cloud/metrics:metrics_server_image",

k8s/cloud/base/kustomization.yaml

@@ -10,7 +10,6 @@ resources:
 - contact_config.yaml
 - proxy_envoy.yaml
 - kuberesolver_role.yaml
-- dns_config.yaml
 - db_config.yaml
 - tls_config.yaml
 - service_config.yaml
@@ -19,8 +18,6 @@ resources:
 - auth_service.yaml
 - api_deployment.yaml
 - api_service.yaml
-- dnsmgr_deployment.yaml
-- dnsmgr_service.yaml
 - plugin_deployment.yaml
 - plugin_service.yaml
 - profile_deployment.yaml

k8s/cloud/base/service_config.yaml

@@ -11,7 +11,6 @@ data:
   PL_PROFILE_SERVICE: kubernetes:///profile-service.plc:51500
   PL_PROJECT_MANAGER_SERVICE: kubernetes:///project-manager-service.plc:50300
   PL_VZMGR_SERVICE: kubernetes:///vzmgr-service.plc:51800
-  PL_DNSMGR_SERVICE: kubernetes:///dnsmgr-service.plc:51900
   PL_ARTIFACT_TRACKER_SERVICE: kubernetes:///artifact-tracker-service.plc:50750
   PL_ELASTIC_SERVICE: https://pl-elastic-es-http.plc:9200
   PL_SCRIPTMGR_SERVICE: kubernetes:///scriptmgr-service.plc:52000

k8s/cloud/base/vzmgr_deployment.yaml

@@ -58,11 +58,6 @@ spec:
             secretKeyRef:
               name: pl-db-secrets
               key: database-key
-        - name: PL_DNSMGR_SERVICE
-          valueFrom:
-            configMapKeyRef:
-              name: pl-service-config
-              key: PL_DNSMGR_SERVICE
         - name: PL_ARTIFACT_TRACKER_SERVICE
           valueFrom:
             configMapKeyRef:

k8s/cloud/dev/service_config.yaml

@@ -11,7 +11,6 @@ data:
   PL_PROFILE_SERVICE: kubernetes:///profile-service.plc-dev:51500
   PL_PROJECT_MANAGER_SERVICE: kubernetes:///project-manager-service.plc-dev:50300
   PL_VZMGR_SERVICE: kubernetes:///vzmgr-service.plc-dev:51800
-  PL_DNSMGR_SERVICE: kubernetes:///dnsmgr-service.plc-dev:51900
   PL_ARTIFACT_TRACKER_SERVICE: kubernetes:///artifact-tracker-service.plc-dev:50750
   PL_ELASTIC_SERVICE: https://pl-elastic-es-http.plc-dev:9200
   PL_SCRIPTMGR_SERVICE: kubernetes:///scriptmgr-service.plc-dev:52000

k8s/cloud/prod/kustomization.yaml

@@ -35,7 +35,6 @@ patchesStrategicMerge:
 - service_config.yaml
 - domain_config.yaml
 - cloud_ingress_ip.yaml
-- dns_config.yaml
 - scriptmgr_config.yaml
 - proxy_envoy.yaml
 patches:

k8s/cloud/prod/service_config.yaml

@@ -11,7 +11,6 @@ data:
   PL_PROFILE_SERVICE: kubernetes:///profile-service.plc:51500
   PL_PROJECT_MANAGER_SERVICE: kubernetes:///project-manager-service.plc:50300
   PL_VZMGR_SERVICE: kubernetes:///vzmgr-service.plc:51800
-  PL_DNSMGR_SERVICE: kubernetes:///dnsmgr-service.plc:51900
   PL_ARTIFACT_TRACKER_SERVICE: kubernetes:///artifact-tracker-service.plc:50750
   PL_ELASTIC_SERVICE: https://pl-elastic-es-http.plc:9200
   PL_SCRIPTMGR_SERVICE: kubernetes:///scriptmgr-service.plc:52000

k8s/cloud/public/kustomization.yaml

@@ -44,9 +44,6 @@ images:
 - name: gcr.io/pixie-oss/pixie-dev/cloud/proxy_server_image
   newName: gcr.io/pixie-oss/pixie-prod/cloud/proxy_server_image
   newTag: latest
-- name: gcr.io/pixie-oss/pixie-dev/cloud/dnsmgr_server_image
-  newName: gcr.io/pixie-oss/pixie-prod/cloud/dnsmgr_server_image
-  newTag: latest
 - name: gcr.io/pixie-oss/pixie-dev/cloud/indexer_server_image
   newName: gcr.io/pixie-oss/pixie-prod/cloud/indexer_server_image
   newTag: latest

k8s/cloud/staging/kustomization.yaml

@@ -32,7 +32,6 @@ patchesStrategicMerge:
 - service_config.yaml
 - domain_config.yaml
 - cloud_ingress_ip.yaml
-- dns_config.yaml
 - proxy_envoy.yaml
 patches:
 - path: db_sidecar.yaml

k8s/cloud/staging/service_config.yaml

@@ -11,7 +11,6 @@ data:
   PL_PROFILE_SERVICE: kubernetes:///profile-service.plc-staging:51500
   PL_PROJECT_MANAGER_SERVICE: kubernetes:///project-manager-service.plc-staging:50300
   PL_VZMGR_SERVICE: kubernetes:///vzmgr-service.plc-staging:51800
-  PL_DNSMGR_SERVICE: kubernetes:///dnsmgr-service.plc-staging:51900
   PL_ARTIFACT_TRACKER_SERVICE: kubernetes:///artifact-tracker-service.plc-staging:50750
   PL_ELASTIC_SERVICE: https://pl-elastic-es-http.plc-staging:9200
   PL_SCRIPTMGR_SERVICE: kubernetes:///scriptmgr-service.plc-staging:52000

k8s/cloud/testing/kustomization.yaml

@@ -32,7 +32,6 @@ patchesStrategicMerge:
 - service_config.yaml
 - domain_config.yaml
 - cloud_ingress_ip.yaml
-- dns_config.yaml
 - proxy_envoy.yaml
 patches:
 - path: db_sidecar.yaml

k8s/cloud/testing/service_config.yaml

@@ -11,7 +11,6 @@ data:
   PL_PROFILE_SERVICE: kubernetes:///profile-service.plc-testing:51500
   PL_PROJECT_MANAGER_SERVICE: kubernetes:///project-manager-service.plc-testing:50300
   PL_VZMGR_SERVICE: kubernetes:///vzmgr-service.plc-testing:51800
-  PL_DNSMGR_SERVICE: kubernetes:///dnsmgr-service.plc-testing:51900
   PL_ARTIFACT_TRACKER_SERVICE: kubernetes:///artifact-tracker-service.plc-testing:50750
   PL_ELASTIC_SERVICE: https://pl-elastic-es-http.plc-testing:9200
   PL_SCRIPTMGR_SERVICE: kubernetes:///scriptmgr-service.plc-testing:52000

scripts/load_dev_db.sh

@@ -82,12 +82,6 @@ bazel run -c opt //src/utils/artifacts/artifact_db_updater:artifact_db_updater -
 
 git checkout main "$versions_file"
 
-# Update database with SSL certs.
-sops --config="${repo_path}"/credentials/.sops.yaml --decrypt "${certs_path}" > "${certs_decoded_path}"
-bazel run -c opt //src/cloud/dnsmgr/load_certs:load_certs -- \
-    --certs_path "${certs_decoded_path}" --postgres_db "pl" --postgres_port "${postgres_port}"
-rm "${certs_decoded_path}"
-
 # Kill kubectl port-forward.
 kill -15 "$!"
 sleep 2

skaffold/skaffold_cloud.yaml

@@ -39,10 +39,6 @@ build:
     context: .
     bazel:
       target: //src/cloud/vzmgr:vzmgr_server_image.tar
-  - image: gcr.io/pixie-oss/pixie-dev/cloud/dnsmgr_server_image
-    context: .
-    bazel:
-      target: //src/cloud/dnsmgr:dnsmgr_server_image.tar
   - image: gcr.io/pixie-oss/pixie-dev/cloud/indexer_server_image
     context: .
     bazel:

src/cloud/vzmgr/BUILD.bazel

@@ -27,7 +27,6 @@ go_library(
     visibility = ["//visibility:private"],
     deps = [
         "//src/cloud/artifact_tracker/artifacttrackerpb:artifact_tracker_pl_go_proto",
-        "//src/cloud/dnsmgr/dnsmgrpb:service_pl_go_proto",
         "//src/cloud/shared/pgmigrate",
         "//src/cloud/shared/vzshard",
         "//src/cloud/vzmgr/controllers",

src/cloud/vzmgr/controllers/BUILD.bazel

@@ -31,7 +31,6 @@ go_library(
     deps = [
         "//src/api/proto/uuidpb:uuid_pl_go_proto",
         "//src/cloud/artifact_tracker/artifacttrackerpb:artifact_tracker_pl_go_proto",
-        "//src/cloud/dnsmgr/dnsmgrpb:service_pl_go_proto",
         "//src/cloud/shared/messages",
         "//src/cloud/shared/messagespb:messages_pl_go_proto",
         "//src/cloud/shared/vzshard",
@@ -76,8 +75,6 @@ go_test(
         "//src/api/proto/uuidpb:uuid_pl_go_proto",
         "//src/cloud/artifact_tracker/artifacttrackerpb:artifact_tracker_pl_go_proto",
         "//src/cloud/artifact_tracker/artifacttrackerpb/mock",
-        "//src/cloud/dnsmgr/dnsmgrpb:service_pl_go_proto",
-        "//src/cloud/dnsmgr/dnsmgrpb/mock",
         "//src/cloud/shared/messagespb:messages_pl_go_proto",
         "//src/cloud/shared/vzshard",
         "//src/cloud/vzmgr/controllers/mock",

src/cloud/vzmgr/controllers/server.go

@@ -39,12 +39,10 @@ import (
 	log "github.com/sirupsen/logrus"
 	"github.com/spf13/viper"
 	"google.golang.org/grpc/codes"
-	"google.golang.org/grpc/metadata"
 	"google.golang.org/grpc/status"
 	"gopkg.in/segmentio/analytics-go.v3"
 
 	"px.dev/pixie/src/api/proto/uuidpb"
-	"px.dev/pixie/src/cloud/dnsmgr/dnsmgrpb"
 	"px.dev/pixie/src/cloud/shared/messages"
 	"px.dev/pixie/src/cloud/shared/messagespb"
 	"px.dev/pixie/src/cloud/shared/vzshard"
@@ -69,11 +67,10 @@ type HandleNATSMessageFunc func(*cvmsgspb.V2CMessage)
 
 // Server is a bridge implementation of evzmgr.
 type Server struct {
-	db           *sqlx.DB
-	dbKey        string
-	dnsMgrClient dnsmgrpb.DNSMgrServiceClient
-	nc           *nats.Conn
-	updater      VzUpdater
+	db      *sqlx.DB
+	dbKey   string
+	nc      *nats.Conn
+	updater VzUpdater
 
 	done chan struct{}
 	once sync.Once
@@ -88,14 +85,13 @@ type VzUpdater interface {
 }
 
 // New creates a new server.
-func New(db *sqlx.DB, dbKey string, dnsMgrClient dnsmgrpb.DNSMgrServiceClient, nc *nats.Conn, updater VzUpdater) *Server {
+func New(db *sqlx.DB, dbKey string, nc *nats.Conn, updater VzUpdater) *Server {
 	s := &Server{
-		db:           db,
-		dbKey:        dbKey,
-		dnsMgrClient: dnsMgrClient,
-		nc:           nc,
-		updater:      updater,
-		done:         make(chan struct{}),
+		db:      db,
+		dbKey:   dbKey,
+		nc:      nc,
+		updater: updater,
+		done:    make(chan struct{}),
 	}
 
 	_ = prometheus.Register(NewStatusMetricsCollector(db))
@@ -694,27 +690,7 @@ func (s *Server) HandleVizierHeartbeat(v2cMsg *cvmsgspb.V2CMessage) {
 	}
 	vizierID := utils.UUIDFromProtoOrNil(req.VizierID)
 
-	// Send DNS address.
-	serviceAuthToken, err := getServiceCredentials(viper.GetString("jwt_signing_key"))
-	if err != nil {
-		log.WithError(err).Error("Could not get service creds from jwt")
-		return
-	}
-
-	ctx := metadata.AppendToOutgoingContext(context.Background(), "authorization",
-		fmt.Sprintf("bearer %s", serviceAuthToken))
-
 	addr := req.Address
-	if req.Address != "" {
-		dnsMgrReq := &dnsmgrpb.GetDNSAddressRequest{
-			ClusterID: req.VizierID,
-			IPAddress: req.Address,
-		}
-		resp, err := s.dnsMgrClient.GetDNSAddress(ctx, dnsMgrReq)
-		if err == nil {
-			addr = resp.DNSAddress
-		}
-	}
 	if req.Port != int32(0) {
 		addr = fmt.Sprintf("%s:%d", addr, req.Port)
 	}

src/cloud/vzmgr/vzmgr_server.go

@@ -35,7 +35,6 @@ import (
 	"google.golang.org/grpc"
 
 	"px.dev/pixie/src/cloud/artifact_tracker/artifacttrackerpb"
-	"px.dev/pixie/src/cloud/dnsmgr/dnsmgrpb"
 	"px.dev/pixie/src/cloud/shared/pgmigrate"
 	"px.dev/pixie/src/cloud/shared/vzshard"
 	"px.dev/pixie/src/cloud/vzmgr/controllers"
@@ -61,27 +60,11 @@ var (
 
 func init() {
 	pflag.String("database_key", "", "The encryption key to use for the database")
-	pflag.String("dnsmgr_service", "dnsmgr-service.plc.svc.cluster.local:51900", "The dns manager service url (load balancer/list is ok)")
 	pflag.String("domain_name", "dev.withpixie.dev", "The domain name of Pixie Cloud")
 
 	prometheus.MustRegister(natsErrorCount)
 }
 
-// NewDNSMgrServiceClient creates a new profile RPC client stub.
-func NewDNSMgrServiceClient() (dnsmgrpb.DNSMgrServiceClient, error) {
-	dialOpts, err := services.GetGRPCClientDialOpts()
-	if err != nil {
-		return nil, err
-	}
-
-	dnsMgrChannel, err := grpc.Dial(viper.GetString("dnsmgr_service"), dialOpts...)
-	if err != nil {
-		return nil, err
-	}
-
-	return dnsmgrpb.NewDNSMgrServiceClient(dnsMgrChannel), nil
-}
-
 // NewArtifactTrackerServiceClient creates a new artifact tracker RPC client stub.
 func NewArtifactTrackerServiceClient() (artifacttrackerpb.ArtifactTrackerClient, error) {
 	dialOpts, err := services.GetGRPCClientDialOpts()
@@ -168,18 +151,12 @@ func main() {
 
 	s := server.NewPLServer(env.New(viper.GetString("domain_name")), mux)
 
-	dnsMgrClient, err := NewDNSMgrServiceClient()
-	if err != nil {
-		log.WithError(err).Fatal("failed to initialize DNS manager RPC client")
-		panic(err)
-	}
-
 	db := pg.MustConnectDefaultPostgresDB()
 	// We have 256 * 2 different sharded goroutines running to handle requests.
 	// Match the same number of allowed db connections.
 	db.SetMaxOpenConns(512)
 	db.SetMaxIdleConns(128)
-	err = pgmigrate.PerformMigrationsUsingBindata(db, "vzmgr_service_migrations",
+	err := pgmigrate.PerformMigrationsUsingBindata(db, "vzmgr_service_migrations",
 		bindata.Resource(schema.AssetNames(), schema.Asset))
 	if err != nil {
 		log.WithError(err).Fatal("Failed to apply migrations")
@@ -207,7 +184,7 @@ func main() {
 	go updater.ProcessUpdateQueue()
 	defer updater.Stop()
 
-	c := controllers.New(db, dbKey, dnsMgrClient, nc, updater)
+	c := controllers.New(db, dbKey, nc, updater)
 	dks := deploymentkey.New(db, dbKey)
 	ds := deployment.New(dks, c)