forked from pixie-io/pixie
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[PC-1511]: Show default export URL placeholder: better label
Summary: Better labeling. Consistently call it `Export URL` rather than path; show the default value as the placeholder when available. When editing a retention script, if the plugin has customExportURL defined, that takes precedence over the top-level default. Test Plan: Visit both plugin configs and data retention script configs. The label and placeholder for export URLs should now consistently call it a URL, and placeholders will show the value that will be used if not overridden there. Reviewers: michelle, vihang Reviewed By: michelle JIRA Issues: PC-1511 Signed-off-by: Nick Lanam <nlanam@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11379 GitOrigin-RevId: 26e2e7d
- Loading branch information
1 parent
81f3977
commit 1607651
Showing
3 changed files
with
11 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters