Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eda.create-db-report): add orphan page and fix foreign key bug #935

Merged

Conversation

khoatxp
Copy link

@khoatxp khoatxp commented Aug 10, 2022

Description

  • Add orphan page
  • Fix an issue where we were missing foreign key constraint for tables with more than 1 foreign keys for sqlite database engine

How Has This Been Tested?

  • Manual testing and local test run

Snapshots:

Screenshot 2022-08-10 at 2 34 15 PM

Checklist:

  • My code follows the style guidelines of this project
  • I have already squashed the commits and make the commit message conform to the project standard.
  • I have already marked the commit with "BREAKING CHANGE" or "Fixes #" if needed.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jinglinpeng jinglinpeng merged commit c15ec40 into sfu-db:develop Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants