Support PostgreSQL numeric type to decimal #806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Postgres transport mappings - Implemented ArrowAssoc for Decimal and Option<Decimal> with appropriate builders and append methods. - Added Decimal128 support in the ArrowTypeSystem. - Updated PostgresArrowTransport to convert Numeric types to Decimal128. - Enhanced tests for Decimal128 handling in Arrow and Postgres integration.
- Changed the conversion of Numeric types from Float64 to Decimal in Postgres transport mappings. - Simplified the TypeConversion implementation for Decimal to return Decimal directly.
…ansport - Updated the conversion mappings for Numeric types to use 'conversion auto' instead of 'conversion option'. - Removed redundant TypeConversion implementations for Decimal and Vec<Option<Decimal> as they were unnecessary.
|
Hi @holicc , thanks for the PR! The code looks good to me. I made some simple changes to fix the CI errors. I also left a few comments on some minor issues. |
…egration - Added DEFAULT_ARROW_DECIMAL_PRECISION, DEFAULT_ARROW_DECIMAL_SCALE, and DEFAULT_ARROW_DECIMAL constants to support Decimal128 in Arrow. - Updated imports in arrow_assoc modules to utilize the new constants. - Removed redundant constant definitions from arrow_assoc implementations.
|
Thank you for taking the time to review the code. I have addressed the issues you pointed out. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#751