Proposed method for interpolation of HRTFs in the time domain #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hagenw
reviewed
Apr 5, 2019
hagenw
reviewed
Apr 7, 2019
There was a problem hiding this comment.
Your changes look good and the test_interpolation_methods runs fine beside the two last plots, but those also fail under Octave for the master branch.
I had also a brief look at the new interpolation and could follow all the steps beside the last one, where I added a small question.
|
Do you know what the problem is with the last two plots in |
hagenw
approved these changes
Apr 8, 2019
|
It was a strange openGL float data exception. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for an alternative HRTF interpolation method in the time domain:
The difference in TOAs is estimated by the maximum of the cross-correlation function. The HRIRs are then shifted to have the same TOA, interpolated and then the resulting HRIR is shifted to the interpolated TOA.
The method can handle an arbitrary number of HRIRs as input which is necessary depending on the used method for point selection.
I also added this additional method in
test_interpolation_methods().What do you think?