Fix a crash, Update to Hou 18.0, clean up some code sty;e #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
const by-value parameters is an old style that isn't encouraged anymore
Make Simulator take a MacGrid by value, per the modern C++ recommendation to pass 'sink' arguments by value then move them int the local member. (Doing this allows the caller to give a copy where wanted, or to move the argument when it's only ever intended as part of the new object)
This is all the custom copy constructor was doing anyway, and with the data members as arrays and vectors, manual allocation and deallocation is no longer needed inside MacGrid. This will also allow for efficient moves of MacGrids.
This will mean manual memory management isn't necessary, and this shouldn't be less efficient when new instances are initialized in _compute_pressures(), since copy elision or move assignment should be used.
Now the default ~SOP_Flipsim() can be used, and manual memory management is not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.