fix: [PR-820] finish updating read paths where zone is available#236
Merged
sigmachirality merged 5 commits intomainfrom Jan 7, 2026
Merged
fix: [PR-820] finish updating read paths where zone is available#236sigmachirality merged 5 commits intomainfrom
sigmachirality merged 5 commits intomainfrom
Conversation
Changed Files
|
Contributor
Greptile SummaryThis PR completes the zone information display by adding zone fields to read paths (contracts and orders) and ensuring the zone from quotes is used in node creation when no zone is explicitly specified. Key Changes:
Technical Note: Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant CLI
participant API
participant Display
Note over User,Display: Read Paths - Displaying Zone Information
User->>CLI: sf orders ls --verbose
CLI->>API: GET /orders
API-->>CLI: orders[] with cluster field
CLI->>Display: OrderDisplay (expanded=true)
Display-->>User: Show zone row (from order.cluster)
User->>CLI: sf contracts ls
CLI->>API: GET /contracts
API-->>CLI: contracts[] with zone field
CLI->>Display: ContractDisplay
Display-->>User: Show zone row (from contract.zone)
Note over User,Display: Write Path - Using Zone from Quote
User->>CLI: sf nodes create (no --zone specified)
CLI->>API: GET /quote
API-->>CLI: quote with zone field
CLI->>CLI: createParams.zone ||= quote.zone
CLI->>API: POST /nodes with zone
API-->>User: Nodes created in zone
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Where zone/cluster information is available, we want to make sure to show it to the user to encourage them to think in terms of zones as much as possible.