build: [PR-1403], [PR-1057] bump commander major version to 14

[sigmachirality]

Makes several small but technically breaking changes to enable upgrading to Commander 14

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
deno.lock	Unsupported file format
package.json	0% smaller
src/lib/buy/index.tsx	0% smaller
src/lib/dev.ts	0% smaller
src/lib/scale/create.tsx	0% smaller

[greptile-apps]

Greptile Overview

Greptile Summary

This PR upgrades commander.js from v12 to v14, addressing a breaking change where multi-character short flags (like -cs, -colo, -rm) are no longer supported. The migration correctly updates these flags to either single-character short flags (-s) or long-form only flags (--colo, --rm).

Key Changes:

• src/lib/scale/create.tsx: -cs → -s for --colocation-strategy (breaking change for users)
• src/lib/buy/index.tsx: -colo → --colo for --colocate (backward compatible via long form)
• src/lib/dev.ts: -rm → --rm for --remove (backward compatible via long form)
• package.json and deno.lock: Updated commander dependencies to v14

The migration follows commander v14's requirement that short flags must be single characters. The --<short> pattern (e.g., --colo) allows multi-character flags as long-form only options.

Confidence Score: 4/5

• This PR is safe to merge with one minor breaking change for existing scripts
• The migration is technically sound and correctly addresses commander v14's breaking changes. However, the -cs → -s change in src/lib/scale/create.tsx introduces a breaking change for users with existing scripts. The other flag migrations (-colo → --colo, -rm → --rm) maintain backward compatibility since users can continue using the long form. The score reflects the clean implementation but accounts for the user-facing breaking change.
• Pay attention to src/lib/scale/create.tsx - users will need to update scripts using -cs to use -s or --colocation-strategy

Important Files Changed

File Analysis

Filename	Score	Overview
package.json	5/5	Updated commander from v12 to v14 and @commander-js/extra-typings accordingly
src/lib/buy/index.tsx	5/5	Migrated -colo to --colo (multi-character short flags no longer supported in commander v14)
src/lib/dev.ts	5/5	Migrated -rm to --rm (multi-character short flags no longer supported in commander v14)
src/lib/scale/create.tsx	4/5	Migrated -cs to -s for colocation-strategy flag, creating a breaking change for existing users

Sequence Diagram

sequenceDiagram
    participant User
    participant CLI
    participant Commander14
    participant CommandHandlers
    
    User->>CLI: Execute command with flags
    CLI->>Commander14: Parse command line arguments
    
    alt Multi-character short flag (e.g., -cs, -colo, -rm)
        Commander14-->>CLI: Error: Invalid flag format (v14 breaking change)
    end
    
    Commander14->>Commander14: Validate single-char short flags only
    
    alt Valid single-char short flag (e.g., -s)
        Commander14->>CommandHandlers: Route to appropriate handler
        CommandHandlers->>CommandHandlers: Execute command logic
        CommandHandlers-->>User: Return result
    end
    
    alt Long flag format (e.g., --colo, --rm, --colocation-strategy)
        Commander14->>CommandHandlers: Route to appropriate handler
        CommandHandlers->>CommandHandlers: Execute command logic
        CommandHandlers-->>User: Return result
    end

Loading

[greptile-apps]

_{4 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}