Fix an oversight in r83294. unquote() should reject bytes. Issue pyth…

…on#9301.
sfc-gh-sfan · Jul 31, 2010 · c049fca · c049fca
1 parent 62069d3
commit c049fca
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/Lib/test/test_urllib.py b/Lib/test/test_urllib.py
@@ -557,6 +557,7 @@ def test_unquoting(self):
                          "%s" % result)
         self.assertRaises((TypeError, AttributeError), urllib.parse.unquote, None)
         self.assertRaises((TypeError, AttributeError), urllib.parse.unquote, ())
+        self.assertRaises((TypeError, AttributeError), urllib.parse.unquote, b'')
 
     def test_unquoting_badpercent(self):
         # Test unquoting on bad percent-escapes

diff --git a/Lib/urllib/parse.py b/Lib/urllib/parse.py
@@ -338,7 +338,7 @@ def unquote(string, encoding='utf-8', errors='replace'):
 
     unquote('abc%20def') -> 'abc def'.
     """
-    if string in (b'', ''):
+    if string == '':
         return string
     res = string.split('%')
     if len(res) == 1: