Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for escaping OsStr #9

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Add support for escaping OsStr #9

wants to merge 17 commits into from

Commits on Feb 6, 2023

  1. Add an implementation of escape for OsStr 

    Signed-off-by: Aalekh Patel <aalekh.gwpeck.7998@icloud.com>
    @aalekhpatel07
    aalekhpatel07 committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    28e8445 View commit details
    Browse the repository at this point in the history

  2. Clippy fix. 

    Signed-off-by: Aalekh Patel <aalekh.gwpeck.7998@icloud.com>
    @aalekhpatel07
    aalekhpatel07 committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    a32705d View commit details
    Browse the repository at this point in the history

  3. Rustfmt fix. 

    Signed-off-by: Aalekh Patel <aalekh.gwpeck.7998@icloud.com>
    @aalekhpatel07
    aalekhpatel07 committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    7d5ca97 View commit details
    Browse the repository at this point in the history

  4. Reorder the implementation to be above tests. 

    Signed-off-by: Aalekh Patel <aalekh.gwpeck.7998@icloud.com>
    @aalekhpatel07
    aalekhpatel07 committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    ebef84f View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2023

  1. Make escape_os_str tests more readable. 

    Signed-off-by: Aalekh Patel <aalekh.gwpeck.7998@icloud.com>
    @aalekhpatel07
    aalekhpatel07 committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    143f0c3 View commit details
    Browse the repository at this point in the history

  2. Make escape tests more readable. 

    Signed-off-by: Aalekh Patel <aalekh.gwpeck.7998@icloud.com>
    @aalekhpatel07
    aalekhpatel07 committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    791a4aa View commit details
    Browse the repository at this point in the history

  3. Use test_case in windows escape tests as well. 

    Signed-off-by: Aalekh Patel <aalekh.gwpeck.7998@icloud.com>
    @aalekhpatel07
    aalekhpatel07 committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    3b964b4 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2023

  1. Add an escape_os_str for Windows.

    @aalekhpatel07
    aalekhpatel07 committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    ae6c50c View commit details
    Browse the repository at this point in the history

  2. Apply rustfmt fixes.

    @aalekhpatel07
    aalekhpatel07 committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    4e148e2 View commit details
    Browse the repository at this point in the history

  3. Refactor escape impls between two modules.

    @aalekhpatel07
    aalekhpatel07 committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    934b6f1 View commit details
    Browse the repository at this point in the history

  4. Make escape for windows more readable.

    @aalekhpatel07
    aalekhpatel07 committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    37d4fc8 View commit details
    Browse the repository at this point in the history

  5. Reserve more bytes.

    @aalekhpatel07
    aalekhpatel07 committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    60219aa View commit details
    Browse the repository at this point in the history

  6. Apply some suggestions from the review.

    @aalekhpatel07
    aalekhpatel07 committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    e94b26f View commit details
    Browse the repository at this point in the history

  7. Apply clippy fixes.

    @aalekhpatel07
    aalekhpatel07 committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    13def30 View commit details
    Browse the repository at this point in the history

  8. Rustfmt fixes.

    @aalekhpatel07
    aalekhpatel07 committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    c0d2a8b View commit details
    Browse the repository at this point in the history

  9. Fix doctest import.

    @aalekhpatel07
    aalekhpatel07 committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    b0bc985 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2023

  1. Make the implementation of escape uniform across both platforms.

    @CdnCentreForChildProtection
    CdnCentreForChildProtection committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    8b281f2 View commit details
    Browse the repository at this point in the history