Added target_arch for repr #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will break non-x86/x86-64 platforms. I think the right way to go here is to have an enum with an unspecified representation with methods to map to and from |
|
Actually, that enum isn't used anywhere, and can probably just be deleted until someone actually implements that chunk of the API. |
|
Ah, here was me just about to do as you suggested! Shall I remove it in the pull request? |
|
Sure |
|
Done, not sure if a comment needs to be left as I'm not familiar with X.509 so I'm probably not the best person to leave one anyway.. |
|
Can you squash the commits together? LGTM other than that, thanks! |
To be added at a later date when the API is expanded
|
Sure, done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c_ulong is u32 on x86
Haven't played with target_arch before but I'm guessing this will continue to work for x86_64 people..