Added RSA_METHOD Bindings #2219
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is probably not all of the bindings, but it's all of the ones from
the documentation:
https://www.openssl.org/docs/man1.1.1/man3/RSA_meth_new.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
RSA_METHODbindings forossl110While the previous engine pr (#2006) is more than enough for me and my own purposes, I had a really hard time getting it through CI, I had a hard time creating a PR from the
ENGINEbindings first, and keeping the scope relatively small. Now, I'm going to try to go about it from the other direction :)There's also the question of testing this thoroughly. I think the only way that this could be tested reasonably is if I create a fake testing only engine, and have it assert that it gets called at various points during the engine lifecycle. @sfackler to have some input on testing, now that I hopefully have a PR with a smaller scope.