Add CMS_verify() method. #1589
Merged
Add CMS_verify() method. #1589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That would be cool to have. Any chances of merging it in? (@sfackler?) |
|
We have been using this in production in a custom build without any problem for around 6 months now. |
|
Hi.
I've rebased the code to the current master.
Ladislav
…On Wed, Feb 8, 2023 at 4:00 PM Lyra ***@***.***> wrote:
We have been using this in production in a custom build without any
problem for around 6 months now.
Any chance of this getting upstreamed ?
—
Reply to this email directly, view it on GitHub
<#1589 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABDGV7NPW32L2W7EACE4GDTWWOYKRANCNFSM5LKGQYQQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Ladislav Sládeček
|
Skepfyr
requested changes
Feb 12, 2023
|
Thanks for the review. |
|
I am sorry, but I clicked to a wrong button by mistake and closed this PR. You probably cannot see my comments as they are in 'Pending' state so I am sending you a printscreen in PDF. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this pull request adds CMS_verify() method. It was already submitted about a year ago. I even did a few improvements according to your suggestions, but in the end, I removed the PR because I no longer needed the functionality for my project. Now I was asked by puru1761 to resubmit the PR, because he needs the function.
Ladislav