Skip to content

CMS: add verify method #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

CMS: add verify method #1078

wants to merge 1 commit into from

Conversation

agalakhov
Copy link
Contributor

No description provided.

@sfackler
Copy link
Owner

This is also implemented in #1034, which exposes more functionality.

@agalakhov
Copy link
Contributor Author

This was in fact based on #1034. I suggest adding separate verify() and verify_detached() methods in order to provide more compile-time checks. The #1034 implementation has a disadvantage that many Some/None combinations make no sense and result in runtime error, so having separate functions would be fine.

I could also add verify_detached() and sign_detached() for symmetry. And also probably detached versions of encrypt() and decrypt().

sfackler
sfackler reviewed Mar 15, 2019
View reviewed changes
openssl/src/cms.rs
pub fn verify(
&self,
certs: Option<&StackRef<X509>>,
store: &X509Store,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

&X509StoreRef

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Will be corrected.

@sfackler
Copy link
Owner

Keeping the detached APIs separate seems reasonable to me.

@agalakhov agalakhov closed this Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfackler sfackler sfackler left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agalakhov @sfackler