Skip to content

Conversation

@bmwwoo
Copy link
Member

@bmwwoo bmwwoo commented Oct 30, 2015

No description provided.

@ericthewry
Copy link
Member

Well want to incorporate this into #73

Not necessary now, but well want to do that in the future.

LGTM

@ericthewry
Copy link
Member

Actually, wait, I take that back. We should call this TwitterShareService or something in case we want to include other social media. Then ShareGameService would manage all of the social media.

I think we should keep ShareGameService and then TwitterShareService managed by it. Then we'll also have FacebookShareService and TumblrShareService or whatever else (not for this PR), and ShareGameService will do whatever initializing and location management needs doing.

@ericthewry
Copy link
Member

LGTM 🚢

bmwwoo added a commit that referenced this pull request Nov 2, 2015
@bmwwoo bmwwoo merged commit 7eeafa4 into master Nov 2, 2015
@bmwwoo bmwwoo deleted the bw-add-twitter branch November 2, 2015 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants