[BEAM-5248] Euphoria to Beam translators should set coders to output `PCollections' #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VaclavPlajt
force-pushed
the
dsl-euphoria
branch
from
2e90276 to
10b9cef
Compare
VaclavPlajt
force-pushed
the
vasek/when-to-set-coder
branch
from
eef0520 to
a8f6832
Compare
…Pcollections`, but do set coders to the outpus `Pcollections`.
VaclavPlajt
force-pushed
the
vasek/when-to-set-coder
branch
from
a8f6832 to
967877c
Compare
dmvk
pushed a commit
that referenced
this pull request
Oct 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translator now sets coders to all output
PCollectionsbut not to inputPCollactions.Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)