-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix logging and silent #195
Conversation
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 389 389
Branches 94 94
=====================================
Hits 389 389 Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 389 389
Branches 94 94
=====================================
Hits 389 389 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super! Thank you :)
Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the |
Thanks Kent, and appreciate the quick review! |
What: This PR resolves #141 . Fixes configurable options for logging levels and silent.
Why: CLI default log level and silent options ('info' and false) override custom options configured in package-scripts.
How: Swap the order in which lodash merges default and config options.
Checklist: