Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure no scripts will be overwritten, when providing case aliases #173

Merged

Conversation

SleepWalker
Copy link
Contributor

What:

Fixed a bug from #172.

How:

There was no check for existence of the scripts during generation of aliases for scripts in camel/kebab cases (kebab-and-camel-casify.js). So if one script after case conversion yields the key that is already taken by the other script in config it will be overwritten.

Now we will check whether alias key is not taken by the other script.

Checklist:

  • Documentation N/A
  • Tests
  • Ready to be merged
  • Added myself to contributors table

@codecov
Copy link

codecov bot commented Mar 10, 2018

Codecov Report

Merging #173 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #173   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines         382    382           
  Branches       92     92           
=====================================
  Hits          382    382
Impacted Files Coverage Δ
src/kebab-and-camel-casify.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9a7b0b...c7dbfb6. Read the comment docs.

Copy link
Collaborator

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@kentcdodds kentcdodds merged commit ee3acda into sezna:master Mar 10, 2018
@SleepWalker SleepWalker deleted the fix-scripts-overwrites-after-case-change branch March 11, 2018 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants