fix: default config values for yml files

[cecilia-sanare]

What:

All nps commands would fail given the following conditions were true:

• User was using a package-scripts.yml instead of a package-scripts.js
• User didn't pass any options to nps

closes #170

Why:

Current implementation makes it impossible to call nps normally without a minor workaround of some sort.

e.g.

scripts:
  echo: echo "this is a test"

config: {}

How:

yml configurations now go through the same post-process as js configurations.

Checklist:

• Documentation N/A
• Tests
• Ready to be merged
• Added myself to contributors table

[cecilia-sanare]

@kentcdodds
Travis seemed to slow down for a second when this started and
its almost as if the cli tests somehow interfered with one another.

I'm guessing they would pass if you reran the build.

EDIT

The only way I've been able to consistently reproduce the issue Travis just ran into was by adding the following to the run-nps.js utility.

async function runNPS(cwd, args = '') {
  // It seems to be somehow linked to one test timing out
  // in combination to the other tests taking a while.
  if (args === '-c ./package-scripts-with-default.js') {
    await new Promise(resolve => setTimeout(resolve, 30000))
  } else {
    await new Promise(resolve => setTimeout(resolve, 10000))
  }
  // ...

[codecov]

Codecov Report

Merging #171 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #171   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines         382    382           
  Branches       92     92           
=====================================
  Hits          382    382

Impacted Files	Coverage Δ
src/bin-utils/parser.js	100% <ø> (ø)	⬆️
src/bin-utils/index.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5769c9...b56b0d2. Read the comment docs.

[cecilia-sanare]

Updating jest-cli seems to have improved the stability of the cli tests.

[cecilia-sanare]

@kentcdodds
This PR should be good to go now. 👍

[kentcdodds]

Seems good. Thanks! Just one question.

[kentcdodds]

Why did you make these changes?

[cecilia-sanare]

I'm guessing how jest-cli resolves paths for coverage changed somehow in the latest version because with this line it wasn't tracking coverage at all.

[kentcdodds]

Huh.... Ok, that's fine. I plan to eventually upgrade this package to use kcd-scripts anyway.

Thanks!

[cecilia-sanare]

I know this has already been merged, but as an addition.

Changing the jest config to the following seems to have the
same effect as removing the collectCoverageFrom line.

module.exports = {
  // ...
  collectCoverageFrom: ['**/*.js'],
  coveragePathIgnorePatterns: [
    '/coverage/',
    // ...
  ],
  // ...
}

[kentcdodds]

Thanks. I'd rather just upgrade this to use kcd-scripts instead.