Skip to content

Commit

Permalink
Updating test cases according to yargs update
Browse files Browse the repository at this point in the history
  • Loading branch information
VivekFitkariwala authored and sezna committed Nov 27, 2019
1 parent 69aaec2 commit 8acd82f
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 10 deletions.
9 changes: 9 additions & 0 deletions .all-contributorsrc
Original file line number Diff line number Diff line change
Expand Up @@ -447,6 +447,15 @@
"infra",
"review"
]
},
{
"login": "VivekFitkariwala",
"name": "Vivek Fitkariwala",
"avatar_url": "https://avatars2.githubusercontent.com/u/3822890?v=4",
"profile": "https://github.com/VivekFitkariwala",
"contributions": [
"code"
]
}
],
"repoType": "github"
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ All the benefits of npm scripts without the cost of a bloated package.json and l
[![downloads][downloads-badge]][npm-stat]
[![MIT License][license-badge]][license]

[![All Contributors](https://img.shields.io/badge/all_contributors-43-orange.svg?style=flat-square)](#contributors)
[![All Contributors](https://img.shields.io/badge/all_contributors-45-orange.svg?style=flat-square)](#contributors)
[![PRs Welcome][prs-badge]][prs]
[![Donate][donate-badge]][donate]
[![Code of Conduct][coc-badge]][coc]
Expand Down Expand Up @@ -519,7 +519,7 @@ Thanks goes to these people ([emoji key][emojis]):
| [<img src="https://avatars.githubusercontent.com/u/2915616?v=3" width="100px;"/><br /><sub><b>Erik Fox</b></sub>](http://www.erikfox.co/)<br />[🐛](https://github.com/kentcdodds/p-s/issues?q=author%3Aerikfox "Bug reports") [💻](https://github.com/kentcdodds/p-s/commits?author=erikfox "Code") [📖](https://github.com/kentcdodds/p-s/commits?author=erikfox "Documentation") [⚠️](https://github.com/kentcdodds/p-s/commits?author=erikfox "Tests") | [<img src="https://avatars.githubusercontent.com/u/5351262?v=3" width="100px;"/><br /><sub><b>Aditya Pratap Singh</b></sub>](http://blog.adityapsingh.com)<br />[👀](#review-addityasingh "Reviewed Pull Requests") | [<img src="https://avatars.githubusercontent.com/u/7687132?v=3" width="100px;"/><br /><sub><b>bumbleblym</b></sub>](https://github.com/bumbleblym)<br />[💻](https://github.com/kentcdodds/p-s/commits?author=bumbleblym "Code") [📖](https://github.com/kentcdodds/p-s/commits?author=bumbleblym "Documentation") | [<img src="https://avatars.githubusercontent.com/u/7091543?v=3" width="100px;"/><br /><sub><b>Islam Attrash</b></sub>](https://twitter.com/IslamAttrash)<br />[💻](https://github.com/kentcdodds/p-s/commits?author=Attrash-Islam "Code") | [<img src="https://avatars.githubusercontent.com/u/7215306?v=3" width="100px;"/><br /><sub><b>JasonSooter</b></sub>](https://github.com/JasonSooter)<br />[📖](https://github.com/kentcdodds/p-s/commits?author=JasonSooter "Documentation") | [<img src="https://avatars1.githubusercontent.com/u/116871?v=3" width="100px;"/><br /><sub><b>Nate Cavanaugh</b></sub>](http://alterform.com)<br />[💻](https://github.com/kentcdodds/p-s/commits?author=natecavanaugh "Code") | [<img src="https://avatars2.githubusercontent.com/u/3534924?v=3" width="100px;"/><br /><sub><b>Wissam Abirached</b></sub>](https://designingforscale.com)<br />[💻](https://github.com/kentcdodds/p-s/commits?author=wabirached "Code") [⚠️](https://github.com/kentcdodds/p-s/commits?author=wabirached "Tests") |
| [<img src="https://avatars1.githubusercontent.com/u/12592677?v=3" width="100px;"/><br /><sub><b>Paweł Mikołajczyk</b></sub>](https://github.com/Miklet)<br />[💻](https://github.com/kentcdodds/p-s/commits?author=Miklet "Code") [⚠️](https://github.com/kentcdodds/p-s/commits?author=Miklet "Tests") | [<img src="https://avatars0.githubusercontent.com/u/1295580?v=3" width="100px;"/><br /><sub><b>Kyle Welch</b></sub>](http://www.krwelch.com)<br />[💻](https://github.com/kentcdodds/p-s/commits?author=kwelch "Code") [⚠️](https://github.com/kentcdodds/p-s/commits?author=kwelch "Tests") | [<img src="https://avatars3.githubusercontent.com/u/22868432?v=3" width="100px;"/><br /><sub><b>Lufty Wiranda</b></sub>](http://instagram.com/luftywiranda13)<br />[💻](https://github.com/kentcdodds/p-s/commits?author=luftywiranda13 "Code") | [<img src="https://avatars6.githubusercontent.com/u/2936644?v=4" width="100px;"/><br /><sub><b>Bhargav Ponnapalli</b></sub>](http://imbhargav5.com)<br />[💻](https://github.com/kentcdodds/p-s/commits?author=imbhargav5 "Code") | [<img src="https://avatars0.githubusercontent.com/u/1538572?v=4" width="100px;"/><br /><sub><b>falieson</b></sub>](https://github.com/Falieson)<br />[📖](https://github.com/kentcdodds/p-s/commits?author=Falieson "Documentation") [🔧](#tool-Falieson "Tools") | [<img src="https://avatars2.githubusercontent.com/u/22251956?v=4" width="100px;"/><br /><sub><b>Suhas Karanth</b></sub>](https://github.com/sudo-suhas)<br />[🐛](https://github.com/kentcdodds/p-s/issues?q=author%3Asudo-suhas "Bug reports") [💻](https://github.com/kentcdodds/p-s/commits?author=sudo-suhas "Code") | [<img src="https://avatars3.githubusercontent.com/u/1228867?v=4" width="100px;"/><br /><sub><b>Eric Skram</b></sub>](http://www.ericskram.com)<br />[📖](https://github.com/kentcdodds/p-s/commits?author=Vpr99 "Documentation") |
| [<img src="https://avatars2.githubusercontent.com/u/11901111?v=4" width="100px;"/><br /><sub><b>Kether Saturnius</b></sub>](http://www.k3th3r.com)<br />[💻](https://github.com/kentcdodds/p-s/commits?author=iamkether "Code") [📖](https://github.com/kentcdodds/p-s/commits?author=iamkether "Documentation") | [<img src="https://avatars2.githubusercontent.com/u/2536916?v=4" width="100px;"/><br /><sub><b>Sviatoslav</b></sub>](https://github.com/SleepWalker)<br />[🐛](https://github.com/kentcdodds/p-s/issues?q=author%3ASleepWalker "Bug reports") [💻](https://github.com/kentcdodds/p-s/commits?author=SleepWalker "Code") | [<img src="https://avatars2.githubusercontent.com/u/1470998?v=4" width="100px;"/><br /><sub><b>Wei Wang</b></sub>](https://github.com/onlywei)<br />[💻](https://github.com/kentcdodds/p-s/commits?author=onlywei "Code") | [<img src="https://avatars2.githubusercontent.com/u/1393142?v=4" width="100px;"/><br /><sub><b>Sami Jaber</b></sub>](http://twitter.com/samjabz)<br />[🐛](https://github.com/kentcdodds/p-s/issues?q=author%3Asamijaber "Bug reports") [💻](https://github.com/kentcdodds/p-s/commits?author=samijaber "Code") | [<img src="https://avatars3.githubusercontent.com/u/28313487?v=4" width="100px;"/><br /><sub><b>Florian Löchle</b></sub>](https://github.com/schottilol)<br />[💻](https://github.com/kentcdodds/p-s/commits?author=schottilol "Code") | [<img src="https://avatars2.githubusercontent.com/u/15851351?v=4" width="100px;"/><br /><sub><b>Kevin J</b></sub>](https://github.com/kevjin)<br />[💻](https://github.com/kentcdodds/p-s/commits?author=kevjin "Code") | [<img src="https://avatars2.githubusercontent.com/u/3784470?v=4" width="100px;"/><br /><sub><b>Ben Teichman</b></sub>](http://www.benteichman.ca)<br />[💻](https://github.com/kentcdodds/p-s/commits?author=effervescentia "Code") [📖](https://github.com/kentcdodds/p-s/commits?author=effervescentia "Documentation") |
| [<img src="https://avatars3.githubusercontent.com/u/12157751?v=4" width="100px;"/><br /><sub><b>Alex Hansen</b></sub>](http://alex-hansen.com)<br />[💻](https://github.com/kentcdodds/p-s/commits?author=sezna "Code") [🚇](#infra-sezna "Infrastructure (Hosting, Build-Tools, etc)") [👀](#review-sezna "Reviewed Pull Requests") |
| [<img src="https://avatars3.githubusercontent.com/u/12157751?v=4" width="100px;"/><br /><sub><b>Alex Hansen</b></sub>](http://alex-hansen.com)<br />[💻](https://github.com/kentcdodds/p-s/commits?author=sezna "Code") [🚇](#infra-sezna "Infrastructure (Hosting, Build-Tools, etc)") [👀](#review-sezna "Reviewed Pull Requests") | [<img src="https://avatars3.githubusercontent.com/u/4335849?v=4" width="100px;"/><br /><sub><b>Casey Primozic</b></sub>](https://cprimozic.com)<br />[🚇](#infra-ameobea "Infrastructure (Hosting, Build-Tools, etc)") [👀](#review-ameobea "Reviewed Pull Requests") | [<img src="https://avatars2.githubusercontent.com/u/3822890?v=4" width="100px;"/><br /><sub><b>Vivek Fitkariwala</b></sub>](https://github.com/VivekFitkariwala)<br />[💻](https://github.com/kentcdodds/p-s/commits?author=VivekFitkariwala "Code") |
<!-- ALL-CONTRIBUTORS-LIST:END -->

This project follows the [all-contributors][all-contributors] specification.
Expand Down
5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"readline-sync": "^1.4.7",
"spawn-command-with-kill": "^1.0.0",
"type-detect": "^4.0.3",
"yargs": "^8.0.2"
"yargs": "14.2.0"
},
"devDependencies": {
"all-contributors-cli": "^4.3.0",
Expand Down Expand Up @@ -63,7 +63,8 @@
],
"rules": {
"max-len": "off",
"max-lines": "off"
"max-lines": "off",
"no-useless-escape": "off"
}
},
"lint-staged": {
Expand Down
14 changes: 8 additions & 6 deletions src/bin-utils/__tests__/parser.js
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ test('happy path', () => {
const {argv, psConfig} = parse('"build --fast"')
expect(mockBinUtils.loadConfig).toHaveBeenCalledTimes(1)
expect(psConfig.isMock).toBe(true)
expect(argv).toMatchObject({_: ['build --fast']})
expect(argv).toEqual(expect.objectContaining({_: [`\"build --fast\"`]}))
})

test('with CLI config', () => {
Expand All @@ -141,11 +141,13 @@ test('with CLI config', () => {
expect(mockBinUtils.loadConfig).toHaveBeenCalledTimes(1)
expect(mockBinUtils.loadCLIConfig).toHaveBeenCalledTimes(1)
expect(psConfig.isMock).toBe(true)
expect(argv).toMatchObject({
_: ['build --fast'],
require: 'ts-node/register',
config: 'package-scripts.ts',
})
expect(argv).toEqual(
expect.objectContaining({
_: [`\"build --fast\"`],
require: 'ts-node/register',
config: 'package-scripts.ts',
}),
)

delete mockFindUp.mock.cliReturn
delete mockBinUtils.mock.cliConfig
Expand Down

0 comments on commit 8acd82f

Please sign in to comment.