Skip to content

Frontend Refactor #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sezanzeb merged 173 commits into from
Jul 23, 2022
Merged

Frontend Refactor #375

sezanzeb merged 173 commits into from
Jul 23, 2022

Conversation

@jonasBoss
Copy link
Collaborator

@jonasBoss jonasBoss commented Apr 20, 2022

No description provided.

jonasBoss added 30 commits April 17, 2022 13:47
@jonasBoss
Merge branch 'main' into frontend-refactor
fe19a66
@jonasBoss
Tests for the GuiEventHandler
b0dfb7c
@jonasBoss
Implement GuiEventHandler
267ce83
@jonasBoss
tests for data manager
6f028dd
@jonasBoss
Merge branch 'beta' into frontend-refactor
c9ee525
@jonasBoss
Implemented data_manager
d2e7273
@jonasBoss
Remove Ellipsis from type hint
01362a0
@jonasBoss
workaround for old pydantic version
6370bbe
@jonasBoss
workaround for old pydantic version
9a00d9d
@jonasBoss
some more tests for data_manager
ba7b8dc
@jonasBoss
Merge branch 'sezanzeb:beta' into beta
04117fa
@jonasBoss
Merge branch 'beta' into frontend-refactor
7bd0230
@jonasBoss
Updated Data Manager
789a1bb
@jonasBoss
move DeviceSelection to its own class
f7986c1
@jonasBoss
Data Manager no longer listens for events
9d20351
@jonasBoss
Moved PresetSelection to its own class
9ea2fa1
@jonasBoss
MappingListBox and SelectionLable Listen to the EventHandler
1e4fe42
@jonasBoss
Merge branch 'main' into frontend-refactor
bfe081a
@jonasBoss
DataManager no longer creates its own data objects in the init
573be16
@jonasBoss
Merge branch 'beta' into frontend-refactor
410c391
@jonasBoss
removed global reader object
6991ca1
@jonasBoss
Changed UI startup
43b86a0
@jonasBoss
created backend Interface
7630dc2
@jonasBoss
event_handler debug logs show function which emit a event
1c4818d
@jonasBoss
some cleanup
578c642
@jonasBoss
added target selector to components
456ead5
@jonasBoss
created code editor component
3f8170a
@jonasBoss
adapted autocompletion & some cleanup
c166d8e
@jonasBoss
black
324a6f0
@jonasBoss
connected some buttons to the event_handler
2f7f794
@sezanzeb
Copy link
Owner

sezanzeb commented Jul 9, 2022 •
edited
Loading

  • draw lines in ui from border to border
    "remove this input" error message when key exists
  • output axis while macro code in text input: human readable error
  • StatusData docstring
  • _private underscores in components.py
  • analog-axis not tested yet
  • "event" messsagebroker message to "selected-event"
  • replacing eval with some parsing
  • rename callbacks in context to notify_callbacks
  • maybe move event_header.py out of the injection folder, since helper uses it as well.
  • document why mapping_handlers are an improvement over the evdev.InputEvent directly from the read_loop in the helper

Here are the paddings/margins in px. I couldn't find it in the current docs anymore, but it was on archive.org:

image

jonasBoss added 20 commits July 13, 2022 23:34
@jonasBoss
rename callback to notify_callback
fb0941a
@jonasBoss
rename event message to selected_event
fa5cda6
@jonasBoss
made read_continuisly private
f4babac
@jonasBoss
typing for autocompletion
2dfb6be
@jonasBoss
docstrings for message_broker messages
85e39f1
@jonasBoss
make components methods and propreties private
8bd71b7
@jonasBoss
gui spacings
a837c06
@jonasBoss
removed eval
c142945
@jonasBoss
make some controller functions private
260bce1
@jonasBoss
move status message generation from data_manager to controller
575a891
@jonasBoss
parse mapping errors in controller for more helpful messages
de23d4c
@jonasBoss
remove system_mapping from code editor
a4810a2
@jonasBoss
More component tests
fd7eb73
@jonasBoss
more tests
2f66a20
@jonasBoss
mypy
c88068a
@jonasBoss
make grab_devices less greedy (partial mitigation for sezanzeb#435)
a622037 
only grab one device if there are multiple which can satisfy the same mapping
@jonasBoss
accumulate more values in test
e2c1230
@jonasBoss
docstrings
156e544
@jonasBoss
Updated status messages
017abb5
@jonasBoss
comments, docstrings, imports
2f336cc
@jonasBoss
Copy link
Collaborator Author

jonasBoss commented Jul 23, 2022 •
edited
Loading

@sezanzeb from my side this is ready to merge. I implemented the changes we discussed in the review.

@sezanzeb sezanzeb merged commit 3637204 into sezanzeb:beta Jul 23, 2022
@sezanzeb
Copy link
Owner

sezanzeb commented Jul 23, 2022 •
edited
Loading

Thanks. I'll be away in August. Would you like to be maintainer?

@jonasBoss
Copy link
Collaborator Author

jonasBoss commented Jul 23, 2022

Yes, I think that makes sense.

@jonasBoss
Copy link
Collaborator Author

jonasBoss commented Jul 23, 2022

When do you think your are able to implement the RelToRelHandler?
I think I will do the a RelToAbs an AbsToAbs in the next days. As soon as we have the missing handlers it would be a good point to finish up the beta branch and create a new release.

@sezanzeb
Copy link
Owner

sezanzeb commented Jul 25, 2022

When do you think your are able to implement the RelToRelHandler?

I honestly don't know if I can start working on it until September

sezanzeb
sezanzeb reviewed Oct 29, 2022
View reviewed changes
tests/unit/test_event_pipeline/test_mapping_handlers.py

class TestRelToBtnHanlder(BaseTests, unittest.IsolatedAsyncioTestCase):
def setUp(self):
self.handler = AxisSwitchHandler(
Copy link
Owner

@sezanzeb sezanzeb Oct 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this creates an AxisSwitchHandler in TestRelToBtnHanlder. Same in TestCombinationHandler

Copy link
Collaborator Author

@jonasBoss jonasBoss Oct 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, that looks like an error. I was probably to lazy with the copy paste.

@jonasBoss jonasBoss mentioned this pull request Feb 21, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sezanzeb sezanzeb sezanzeb left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonasBoss @sezanzeb