Skip to content

add consistency, fix display of times, update readme, show final results time#1

Open
finalcut wants to merge 24 commits intosezane:masterfrom
finalcut:pr-offer
Open

add consistency, fix display of times, update readme, show final results time#1
finalcut wants to merge 24 commits intosezane:masterfrom
finalcut:pr-offer

Conversation

@finalcut
Copy link

@finalcut finalcut commented Dec 8, 2020

I made some changes to your fork so figured I'd offer them back to you.

I renamed your new argument of write_weights_file to writeWeightFile to match the orginal authors style for aguments.

Some other changes:

  • fixed time formatting
  • improved time computation for each thread
  • defaulted threads to 4 instead of 2
  • updated readme documentation
  • fixed width of results table to be more readable
  • added new change to show total time across all threads (stolen and modified PR waiting on OP repo)

Hope you can find some use in them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant