Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with VSAN Capacity and API version 6.7.1 #181

Closed
adestis-mb opened this issue Feb 12, 2019 · 7 comments
Closed

Issues with VSAN Capacity and API version 6.7.1 #181

adestis-mb opened this issue Feb 12, 2019 · 7 comments
Assignees

Comments

@adestis-mb
Copy link

Hello all,

we are using script version 0.9.181 of Sexigraf.
Our vSphere environment is running on 6.7 Update 1.
The capacity information is not working anymore since we updated from 6.5 to 6.7.1.

In the ViPullStatistics we see the following warning:
/root/VsanPullStatistics.pl line250 - WARN Argument "6.7.1" isn't numeric in numeric ge (>=) at /root/VsanPullStatistics.pl line 250.

On that line in the file VsanPullStatistics.pl there is no relevant statement.
But on line 209 there is the following which seems to be related:
if ($host_api >= 6.7) {

I think it's not such a good idea to compare a string with a number using the greater or equal operator.
Maybe it's better using a module like https://metacpan.org/pod/Version::Compare

Regards
Markus

@rschitz rschitz self-assigned this Feb 12, 2019
@rschitz
Copy link
Member

rschitz commented Feb 12, 2019

Hi Markus,
Actually we already solved that issue but didn't updated the code yet.
Regarding the capacity information, did you applied the patch published on our website?

@adestis-mb
Copy link
Author

Hello Raphaël,
we are always using the "update package" menu of Sexigraf.
It shows us that we are using 0.99e1 "White Forest".
But I downloaded now the zip file and I saw that at least the PullVsanStatistics.pl file is much newer.
Maybe the update functionality is not working.

I have no manually replaced the PullVsanStatistics.pl file with the one from the source bundle.

@adestis-mb
Copy link
Author

Looks like it's not working anymore at all.
It probably requires everything to be up to date.
Is there a documentation for manually upgrading?

@adestis-mb
Copy link
Author

A fresh installation of the .ova file from the website together with the upgrade to 0.99e1 brought me to the same status.
As workaround I have now changed the line 250 from:
if ($host_api >= 6.7) {
to
if ($host_api eq '6.7' or $host_api eq '6.7.1') {

No errors on the VsanDisksPullStatistics.log anymore
but there are still errors on the dashboard (VMware VSAN Capacity) about an internal server error.

Looks like VSAN capacity is completely broken..

rschitz added a commit that referenced this issue Feb 13, 2019
@rschitz
Copy link
Member

rschitz commented Feb 13, 2019

Hi Markus, could you try this version of the script please? https://github.com/sexibytes/sexigraf/blob/dev/root/VsanPullStatistics.pl

@adestis-mb
Copy link
Author

Really great, it's working again.

Thank you very much

@rschitz
Copy link
Member

rschitz commented Feb 15, 2019

Thank YOU for your support ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants