Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

House Cleaner not expanding subfolders #120

Closed
vmdude opened this issue Jul 18, 2017 · 2 comments
Closed

House Cleaner not expanding subfolders #120

vmdude opened this issue Jul 18, 2017 · 2 comments
Assignees
@vmdude
Labels
bug
Milestone
0.99e - White Forest

Comments

@vmdude
Copy link
Member

vmdude commented Jul 18, 2017

It seems House Cleaner do not expand subfolders anymore, we have to check where this bug comes from
@vmdude vmdude added the bug label Jul 18, 2017
@vmdude vmdude added this to the 0.99e - White Forest milestone Jul 18, 2017
@vmdude vmdude self-assigned this Jul 18, 2017
@vmdude
Copy link
Member Author

vmdude commented Jul 18, 2017

With commit 485cdcc we decided to limit display to directories only, as we encounter some issues displaying huge amount of files.

We switched from PHP function scandir() to glob().
However glob() function does not return . and .. values, so we missed a conditional check.

There was no impact for folders with more than 2 subfolders, but on a small platform, some elements may not be shown.

vmdude added a commit that referenced this issue Jul 18, 2017
@vmdude
Fix #120
13ac6fc 
Remove old `scandir()` conditional check
@vmdude
Copy link
Member Author

vmdude commented Jul 18, 2017 •
edited
Loading

Fixed with 13ac6fc

@vmdude vmdude closed this as completed Jul 18, 2017
@vmdude vmdude mentioned this issue Aug 15, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vmdude vmdude

Labels
bug
Projects
None yet
Milestone
0.99e - White Forest
Development

No branches or pull requests
1 participant
@vmdude