Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consider length scale in normalization #98

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

severinstrobl
Copy link
Owner

When examining the length of the normal vector obtained using Newell's method prior to the actual normalization, the length scale has to be taken into account.

Fixes: #96

When examining the length of the normal vector obtained using Newell's
method prior to the actual normalization, the length scale has to be
taken into account.

Fixes: #96
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.22%. Comparing base (ad9bde3) to head (7b56b79).
Report is 44 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #98      +/-   ##
===========================================
+ Coverage    93.30%   95.22%   +1.91%     
===========================================
  Files            1        1              
  Lines          851      816      -35     
  Branches       156      145      -11     
===========================================
- Hits           794      777      -17     
+ Misses          10        4       -6     
+ Partials        47       35      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

C++ benchmark results

Benchmark Reference (351d479) Current (d447ddb)
hex_overlap_volume_aabb 8.46 ns 8.36 ns: 1.01x faster
normal_newell 66.2 ns 65.5 ns: 1.01x faster
tet_overlap_volume 1.29 us 1.28 us: 1.01x faster
Geometric mean (ref) 1.01x faster

Benchmark hidden because not significant (3): hex_overlap_volume, regularized_wedge, tet_overlap_volume_aabb

Copy link

sonarcloud bot commented Sep 11, 2024

@severinstrobl severinstrobl marked this pull request as ready for review September 11, 2024 20:57
@severinstrobl severinstrobl merged commit d2a165e into develop Sep 11, 2024
41 checks passed
@severinstrobl severinstrobl deleted the normal_newell_scale branch September 11, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant