Abort domain cache refreshment retry during shutdown (uber#2672)

* Abort domain cache refreshment retry during shutdown
sevein · Oct 16, 2019 · 6c8d531 · 6c8d531
1 parent df19cca
commit 6c8d531
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/common/cache/domainCache.go b/common/cache/domainCache.go
@@ -387,8 +387,13 @@ func (c *domainCache) refreshLoop() {
 			return
 		case <-timer.C:
 			for err := c.refreshDomains(); err != nil; err = c.refreshDomains() {
-				c.logger.Error("Error refreshing domain cache", tag.Error(err))
-				time.Sleep(DomainCacheRefreshFailureRetryInterval)
+				select {
+				case <-c.shutdownChan:
+					return
+				default:
+					c.logger.Error("Error refreshing domain cache", tag.Error(err))
+					time.Sleep(DomainCacheRefreshFailureRetryInterval)
+				}
 			}
 		}
 	}