Skip to content

Upkeep/christmas updates: bugfixes and more #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Dec 27, 2023
Merged

Conversation

sevagh
Copy link
Owner

@sevagh sevagh commented Dec 24, 2023

No description provided.

@sevagh sevagh mentioned this pull request Dec 24, 2023
@sevagh
Copy link
Owner Author

sevagh commented Dec 24, 2023

I know my sine code is buggy (see #72)

I can use librosa's tone function to generate a txt file with vector values for testing sinewaves.

@sevagh sevagh force-pushed the upkeep/christmas-updates branch from f0886a1 to 6c0f24a Compare December 27, 2023 13:39
@sevagh sevagh force-pushed the upkeep/christmas-updates branch from d0bac0a to 825f4fe Compare December 27, 2023 13:42
@sevagh sevagh merged commit faa04bb into master Dec 27, 2023
@sevagh sevagh deleted the upkeep/christmas-updates branch December 27, 2023 13:47
@sevagh
Copy link
Owner Author

sevagh commented Dec 27, 2023

For posterity

I know my sine code is buggy (see #72)

The sine wave was not the buggy one, but in fact the effect of a power-of-two size on the autocorrelation function (through a strange behavior of ffts in anthonix/ffts#65)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant