This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
Editor Plugin Examples using EGUI #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Very nice! Thanks for working on this 😄 I've tested the changes and everything seems to work well. If you could you take care of the minor comments I left we should be ready to merge 👍 |
setzer22
reviewed
Aug 28, 2021
… the example. - Main Screen - Dock To make this work, the `GodotEguiExample` and `GodotEgui` NativeClasses needed to be registered as tool classes.
|
Looks good to me! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two Editor Plugin samples by adding some tool scripts based on the Godot Tutorials.
This includes
To make this work, the
GodotEguiExampleandGodotEguiNativeClasses needed to be registered as tool classes.As discussed in Discord, converting the classes to tool scripts may have some issues related to hot reloading. Based on my testing, this only appears to affect godot if you are currently using the editor actively during a build while where the native library may be deleted.
I believe this can be mitigated in real projects by either
Let me know if you would like to include any changes. For the plugin .cfgs, I just left the author as myself, but if you'd like to change it, I don't have a problem with it :)