Skip to content

Conversation

@bl0up
Copy link
Collaborator

@bl0up bl0up commented May 29, 2024

No description provided.

@github-actions github-actions bot added the feat label May 29, 2024
@github-actions
Copy link

github-actions bot commented May 29, 2024

LCOV of commit 111aa6f during Branch #11

Summary coverage rate:
  lines......: 90.0% (45 of 50 lines)
  functions..: 94.7% (18 of 19 functions)
  branches...: 50.0% (16 of 32 branches)

Files changed coverage rate:
                                          |Lines       |Functions  |Branches    
  Filename                                |Rate     Num|Rate    Num|Rate     Num
  ==============================================================================
  contracts/ExampleERC721a.sol            |95.0%     40| 100%    13|53.6%     28
  contracts/extensions/ERC721Whitelist.sol|70.0%     10|83.3%     6|25.0%      4

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Comment on lines +44 to +47
require(
_verify(_leaf(allowance, payload), proof),
"Invalid Merkle Tree proof supplied."
);

Check notice

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-custom-error-not-require

Consider using custom errors as they are more gas efficient while allowing developers to describe the error in detail using NatSpec.
Comment on lines +44 to +47
require(
_verify(_leaf(allowance, payload), proof),
"Invalid Merkle Tree proof supplied."
);

Check notice

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-short-revert-string

Shortening revert strings to fit in 32 bytes will decrease gas costs for deployment and gas costs when the revert condition has been met.
@bl0up bl0up merged commit 32351d8 into main May 29, 2024
@bl0up bl0up deleted the feat/hybrid branch May 29, 2024 15:26
roderik pushed a commit that referenced this pull request Jun 26, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| @​graphprotocol/graph-cli | [`0.76.0` ->
`0.77.0`](https://renovatebot.com/diffs/npm/@graphprotocol%2fgraph-cli/0.76.0/0.77.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@graphprotocol%2fgraph-cli/0.77.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@graphprotocol%2fgraph-cli/0.77.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@graphprotocol%2fgraph-cli/0.76.0/0.77.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@graphprotocol%2fgraph-cli/0.76.0/0.77.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Configuration

📅 **Schedule**: Branch creation - "after 10pm every weekday,before 5am
every weekday,every weekend" (UTC), Automerge - At any time (no schedule
defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/settlemint/btp-smartcontractsets).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjQxMy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants