This repository was archived by the owner on Jun 20, 2024. It is now read-only.
Don't print out error arguments on Windows#57
Merged
Conversation
Collaborator
|
Oh nice. Yep, I totally agree ;), I probably left it there not by design. Thanks |
Owner
Author
|
I figured as such! :) Thank you for this great library, I'm using it for quite a large project and this library is essential. Thank you for the quick reply. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Printing this information is not appropriate as it cannot be disabled or ignored in application code.
It would be quite frustrating if I had to vendor this dependency just to remove a single line.
Also, can we have a new release of this package on PyPI?