Added code to output libSession logs #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpretty-cyro
force-pushed
the
feature/libsession-logging
branch
from
e4a442a to
3a339b1
Compare
SessionHero01
approved these changes
Mar 3, 2025
| break; | ||
| } | ||
|
|
||
| __android_log_print(prio, LOG_TAG, "%.*s [%.*s]", |
There was a problem hiding this comment.
Nice! Didn't know %.*s exists
There was a problem hiding this comment.
Mm yea pretty convenience 😁
There was a problem hiding this comment.
FYI there's actually no need to have this header file, given you aren't referencing this JNI method else where in C++ land, as long as the symbol is marked as JNIEXPORT it is all good to go.
There was a problem hiding this comment.
Ah nice, I'll remove it then
SessionHero01
approved these changes
Mar 4, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a wrapper around the
libSessionlogging code routing logs from withinlibSessionto come out via__android_log_print- can be setup by callingLogger.initLogger()somewhere (for testing I had it within theConfigFactoryinit but wasn't sure where or if these logs were desired so haven't included the init call for now)