SES-763 Contact block and delete functionality #994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found an issue where deleted contacts do not have to go through the message request procedure when messaging a recipient who has deleted them - working on it. |
app/src/main/java/org/thoughtcrime/securesms/home/HomeActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/home/search/GlobalSearchAdapter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/database/ThreadDatabase.java
Outdated
Show resolved
Hide resolved
| long threadId = getThreadIdIfExistsFor(address); | ||
| DatabaseComponent.get(context).sessionContactDatabase().deleteContact(address); | ||
| DatabaseComponent.get(context).recipientDatabase().deleteRecipient(address); | ||
| DatabaseComponent.get(context).threadDatabase().deleteThread(threadId); |
There was a problem hiding this comment.
You are already in the threadDatabase so you don't need to fetch it all form the DatabaseComponent.
Furthermore there is already a deleteConversation which seems to do a lot more than deleting the thread. Isn't it what you want to call instead?
app/src/main/java/org/thoughtcrime/securesms/database/ThreadDatabase.java
Outdated
Show resolved
Hide resolved
|
Also need to consider removing the entry from the config system - our source of truth of user data. |
app/src/main/java/org/thoughtcrime/securesms/database/RecipientDatabase.java
Outdated
Show resolved
Hide resolved
Using coroutine properly
app/src/main/java/org/thoughtcrime/securesms/contacts/SelectContactsToInviteToGroupActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/database/SessionContactDatabase.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/database/ThreadDatabase.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/home/HomeViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/home/HomeViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/home/search/GlobalSearchAdapter.kt
Outdated
Show resolved
Hide resolved
Comment on lines
22
to
25
| private val accountId: String, | ||
| private val contactName: String, | ||
| private val blockContact: (String) -> Unit, | ||
| private val deleteContact: (String) -> Unit, |
There was a problem hiding this comment.
I think you have to do empty constructor for a fragment and pass all parameters through arguments, and all callback with the fragment callback pattern, otherwise it won't survive the backstack
…ntactsToInviteToGroupActivity.kt Co-authored-by: SessionHero01 <180888785+SessionHero01@users.noreply.github.com>
…l.kt Co-authored-by: SessionHero01 <180888785+SessionHero01@users.noreply.github.com>
SessionHero01
approved these changes
Apr 8, 2025
SessionHero01
approved these changes
Apr 8, 2025
ThomasSession
deleted the
fix/SES763_contact_block_and_delete_functionality
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to long-press on a contact and choose to either block or delete them via a pop-up menu.
To access the functionality hit the search button in the top-right of the home activity then long press on a contact.
Known Issues:
i.) The pop-up menu does not have correctly rounded corners,
ii.) The pop-up menu top-left is not aligned to the centre of the contact-being-deleted's profile image as per the figma design.
I have tried many, many different ways of doing these seemingly-simple things, but to no avail. As such I leave this fine-tuning to a higher power.