[SES-3427] - Fix problem resuming message send job when upload completes #990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasSession
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when an attachment upload job completes, it tries to resume the
MessageSendJobso that theMessageSendJobcan check if all attachments have been uploaded. The problem is, if then theMessageSendJobfinds out there are still attachments to upload, the resuming fromAttachmentUploadJobwill no longer trigger aMessageSendJob, hence no one is going to send the message out. The issue is a fix back in 2021 where apending tasksset was introduced to try to fix duplicated message issue, and accidentally limit the number of times theMessageSendJobcould be brought back.The fix is properly updating the
pending jobso that theMessageSendJobcan get executed again on the final attachment upload.