Fix empty state showing incorrectly #1117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasSession
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use to call
updateEmptyStatewhen you close search screen, but we have tidied up the view model, the home screen's state has nothing to do with search anymore, so it's actually harmful to call theupdateEmptyStatefrom the search's perspective: so in previous refactoring of search screen, thesetSearchShownis tied to the view model's state so it gets called even when you haven't done anything to the search (it's to make sure we execute the UI states needed for a "hidden" search).This PR removes the empty state meddling from the search logic and now it shows the right screen.